Skip to content

Commit 51ccc89

Browse files
committed
Add comment about why we allow data_vars='minimial' for concat over datarrays
1 parent 4f38292 commit 51ccc89

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

xarray/core/concat.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -797,6 +797,10 @@ def _dataarray_concat(
797797
"The elements in the input list need to be either all 'Dataset's or all 'DataArray's"
798798
)
799799

800+
# Allow passing old or new default even though we always use `data_vars="all"`
801+
# when passing off to `_dataset_concat`. This allows people to explicitly
802+
# set the data_vars value to the new default without worrying about whether
803+
# they have datasets or dataarrays.
800804
if not isinstance(data_vars, CombineKwargDefault) and data_vars not in [
801805
"all",
802806
"minimal",

0 commit comments

Comments
 (0)