Use emit_user_level_warning rather than warnings.warn

Author: jsignell

xarray/core/alignment.py

@@ -2,7 +2,6 @@
 
 import functools
 import operator
-import warnings
 from collections import defaultdict
 from collections.abc import Callable, Hashable, Iterable, Mapping
 from contextlib import suppress
@@ -21,7 +20,7 @@
     safe_cast_to_index,
 )
 from xarray.core.types import T_Alignable
-from xarray.core.utils import is_dict_like, is_full_slice
+from xarray.core.utils import emit_user_level_warning, is_dict_like, is_full_slice
 from xarray.core.variable import Variable, as_compatible_data, calculate_dimensions
 from xarray.util.deprecation_helpers import CombineKwargDefault
 
@@ -424,7 +423,7 @@ def align_indexes(self) -> None:
                         isinstance(self.join, CombineKwargDefault)
                         and self.join != "exact"
                     ):
-                        warnings.warn(
+                        emit_user_level_warning(
                             self.join.warning_message(
                                 "This change will result in the following ValueError:"
                                 "cannot be aligned with join='exact' because "
@@ -435,8 +434,7 @@ def align_indexes(self) -> None:
                                 ),
                                 recommend_set_options=False,
                             ),
-                            category=FutureWarning,
-                            stacklevel=2,
+                            FutureWarning,
                         )
                     if self.join == "exact":
                         raise ValueError(

xarray/core/concat.py

@@ -1,6 +1,5 @@
 from __future__ import annotations
 
-import warnings
 from collections.abc import Hashable, Iterable
 from typing import TYPE_CHECKING, Any, Union, overload
 
@@ -19,6 +18,7 @@
     merge_collected,
 )
 from xarray.core.types import T_DataArray, T_Dataset, T_Variable
+from xarray.core.utils import emit_user_level_warning
 from xarray.core.variable import Variable
 from xarray.core.variable import concat as concat_vars
 from xarray.util.deprecation_helpers import (
@@ -369,14 +369,13 @@ def process_subset_opt(opt, subset):
             if opt == "different":
                 if isinstance(compat, CombineKwargDefault) and compat != "override":
                     if not isinstance(opt, CombineKwargDefault):
-                        warnings.warn(
+                        emit_user_level_warning(
                             compat.warning_message(
                                 "This change will result in the following ValueError: "
                                 f"Cannot specify both {subset}='different' and compat='override'.",
                                 recommend_set_options=False,
                             ),
-                            category=FutureWarning,
-                            stacklevel=2,
+                            FutureWarning,
                         )
 
                 if compat == "override":
@@ -462,13 +461,12 @@ def process_subset_opt(opt, subset):
                 and opt != "minimal"
                 and original != concat_over
             ):
-                warnings.warn(
+                emit_user_level_warning(
                     opt.warning_message(
                         "This is likely to lead to different results when multiple datasets "
                         "have matching variables with overlapping values.",
                     ),
-                    category=FutureWarning,
-                    stacklevel=2,
+                    FutureWarning,
                 )
         else:
             valid_vars = tuple(getattr(datasets[0], subset))

xarray/core/merge.py

@@ -1,6 +1,5 @@
 from __future__ import annotations
 
-import warnings
 from collections import defaultdict
 from collections.abc import Hashable, Iterable, Mapping, Sequence, Set
 from typing import TYPE_CHECKING, Any, NamedTuple, Union
@@ -16,7 +15,13 @@
     filter_indexes_from_coords,
     indexes_equal,
 )
-from xarray.core.utils import Frozen, compat_dict_union, dict_equiv, equivalent
+from xarray.core.utils import (
+    Frozen,
+    compat_dict_union,
+    dict_equiv,
+    emit_user_level_warning,
+    equivalent,
+)
 from xarray.core.variable import Variable, as_variable, calculate_dimensions
 from xarray.util.deprecation_helpers import (
     _COMPAT_DEFAULT,
@@ -306,13 +311,12 @@ def merge_collected(
                         and compat == "no_conflicts"
                         and len(variables) > 1
                     ):
-                        warnings.warn(
+                        emit_user_level_warning(
                             compat.warning_message(
                                 "This is likely to lead to different results when "
                                 "combining overlapping variables with the same name.",
                             ),
-                            category=FutureWarning,
-                            stacklevel=2,
+                            FutureWarning,
                         )
                 except MergeError:
                     if compat != "minimal":