Skip to content

Commit cadc9dc

Browse files
committed
[-] Fixes issue w/ post_delete / Adds delete test
1 parent 584a9b0 commit cadc9dc

File tree

2 files changed

+14
-1
lines changed

2 files changed

+14
-1
lines changed

easyaudit/signals/model_signals.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -302,6 +302,9 @@ def post_delete(sender, instance, using, **kwargs):
302302
user = None
303303
c_t = ContentType.objects.get_for_model(instance)
304304

305+
# object id to be used later
306+
obj_id = instance.pk
307+
305308
def crud_flow():
306309
try:
307310
with transaction.atomic(using=DATABASE_ALIAS):
@@ -311,7 +314,7 @@ def crud_flow():
311314
'object_repr': str(instance),
312315
'object_json_repr': object_json_repr,
313316
'content_type_id': c_t.id,
314-
'object_id': instance.pk,
317+
'object_id': obj_id,
315318
'user_id': getattr(user, 'id', None),
316319
'datetime': timezone.now(),
317320
'user_pk_as_string': str(user.pk) if user else user

easyaudit/tests/test_app/tests.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,16 @@ def test_fake_update(self):
9090
obj.save()
9191
self.assertEqual(2, crud_event_qs.count())
9292

93+
def test_delete(self):
94+
obj = self.Model.objects.create()
95+
crud_event_qs = CRUDEvent.objects.filter(object_id=obj.id, content_type=ContentType.objects.get_for_model(obj))
96+
self.assertEqual(1, crud_event_qs.count())
97+
98+
obj_id = obj.pk
99+
obj.delete()
100+
crud_event_qs = CRUDEvent.objects.filter(object_id=obj_id, content_type=ContentType.objects.get_for_model(obj))
101+
self.assertEqual(2, crud_event_qs.count())
102+
93103

94104
class TestAuditUUIDModels(TestAuditModels):
95105
Model = TestUUIDModel

0 commit comments

Comments
 (0)