Skip to content

Commit d6edadb

Browse files
authored
Fix: Consistent Card Heights on Ambassadors Page and Update Twitter Logo to X (#1256)
* fix[ambassadors]: ensure consistent card heights across all cards * refactor[ambassadors]: fix existing typo in SocialIcons * feat[ambassadors]: change twitter logo to x
1 parent 5114356 commit d6edadb

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

components/AmbassadorsCard.tsx

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -55,11 +55,11 @@ const SocialIcon = ({ platform }: { platform: SocialIcons }) => {
5555
twitter: (
5656
<svg
5757
className='w-7 h-7 text-gray-600 dark:text-gray-400 hover:text-gray-900 dark:hover:text-gray-100'
58-
viewBox='0 0 24 24'
58+
viewBox='0 0 20 16'
5959
fill='currentColor'
6060
xmlns='http://www.w3.org/2000/svg'
6161
>
62-
<path d='M23.954 4.569c-.885.389-1.83.654-2.825.775a4.932 4.932 0 0 0 2.163-2.723 9.85 9.85 0 0 1-3.127 1.195 4.916 4.916 0 0 0-8.374 4.482A13.936 13.936 0 0 1 1.64 3.161 4.916 4.916 0 0 0 3.195 9.86a4.897 4.897 0 0 1-2.229-.616v.061a4.919 4.919 0 0 0 3.946 4.827 4.897 4.897 0 0 1-2.224.085 4.923 4.923 0 0 0 4.604 3.42A9.869 9.869 0 0 1 .977 19.569a13.94 13.94 0 0 0 7.548 2.211c9.056 0 14.012-7.497 14.012-13.986 0-.213-.005-.425-.015-.636A9.936 9.936 0 0 0 24 4.59a9.94 9.94 0 0 1-2.046.561z' />
62+
<path d='M12.6.75h2.454l-5.36 6.142L16 15.25h-4.937l-3.867-5.07-4.425 5.07H.316l5.733-6.57L0 .75h5.063l3.495 4.633L12.601.75Zm-.86 13.028h1.36L4.323 2.145H2.865z' />
6363
</svg>
6464
),
6565
linkedin: (
@@ -114,15 +114,15 @@ const AmbassadorCard = ({ ambassador }: { ambassador: Ambassador }) => {
114114
contributions = [],
115115
} = ambassador;
116116

117-
const SocialIconss: SocialIcons[] = [
117+
const SocialIcons: SocialIcons[] = [
118118
'github',
119119
'twitter',
120120
'mastodon',
121121
'linkedin',
122122
];
123123

124124
return (
125-
<div className='relative max-w-sm md:max-w-md lg:max-w-lg mx-auto bg-white dark:bg-gray-800 shadow-lg rounded-lg overflow-hidden my-4 transition-all duration-300 h-fit'>
125+
<div className='relative flex flex-col max-w-sm md:max-w-md lg:max-w-lg mx-auto bg-white dark:bg-gray-800 shadow-lg rounded-lg overflow-hidden my-4 h-full'>
126126
<div className='absolute top-0 right-0 w-1 h-20 bg-black dark:bg-gray-400'></div>
127127
<div className='absolute bottom-100 right-0 w-20 h-1 bg-black dark:bg-gray-400'></div>
128128
<div className='absolute bottom-0 left-0 w-1 h-20 bg-black dark:bg-gray-400'></div>
@@ -137,7 +137,7 @@ const AmbassadorCard = ({ ambassador }: { ambassador: Ambassador }) => {
137137
onError={() => setImgSrc(`/img/ambassadors/${name}.jpg`)}
138138
/>
139139

140-
<div className='p-6'>
140+
<div className='flex flex-col flex-grow p-6'>
141141
<h3 className='text-xl font-semibold mb-2 text-gray-900 dark:text-white'>
142142
{name}
143143
</h3>
@@ -157,8 +157,8 @@ const AmbassadorCard = ({ ambassador }: { ambassador: Ambassador }) => {
157157
</p>
158158
)}
159159

160-
<div className='flex justify-center mb-4'>
161-
{SocialIconss.map((platform) => {
160+
<div className='flex justify-center mb-4 mt-auto'>
161+
{SocialIcons.map((platform) => {
162162
const username = ambassador[platform];
163163
return username ? (
164164
<a

0 commit comments

Comments
 (0)