Skip to content

Commit 51c1fc1

Browse files
authored
Merge pull request #42 from richmolj/fix-specs
Fix specs for Rails 5.1
2 parents f52396a + 2c99c28 commit 51c1fc1

File tree

3 files changed

+11
-12
lines changed

3 files changed

+11
-12
lines changed

gemfiles/rails_5.gemfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
source "https://rubygems.org"
44

5-
gem "rails", ['>= 5.0', '< 5.1']
5+
gem "rails", "~> 5.0"
66
gem "jsonapi-rails", "~> 0.1.0", :require => "jsonapi/rails"
77
gem "rspec-rails"
88

spec/integration/rails/persistence_spec.rb

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -48,12 +48,12 @@ def do_post
4848
end
4949

5050
def do_put(id)
51-
put :update, id: id, params: payload
51+
put :update, params: payload.merge(id: id)
5252
end
5353

5454
before do
55-
@request.headers['Accept'] = Mime::JSON
56-
@request.headers['Content-Type'] = Mime::JSON.to_s
55+
@request.headers['Accept'] = Mime[:json]
56+
@request.headers['Content-Type'] = Mime[:json].to_s
5757

5858
routes.draw {
5959
post "create" => "anonymous#create"
@@ -138,12 +138,12 @@ def do_put(id)
138138
let(:employee) { Employee.create!(first_name: 'Joe') }
139139

140140
it 'deletes the object' do
141-
delete :destroy, id: employee.id
141+
delete :destroy, params: { id: employee.id }
142142
expect { employee.reload }.to raise_error(ActiveRecord::RecordNotFound)
143143
end
144144

145145
it 'responds with object' do
146-
delete :destroy, id: employee.id
146+
delete :destroy, params: { id: employee.id }
147147
expect(json_item['id']).to eq(employee.id.to_s)
148148
expect(json_item['first_name']).to eq('Joe')
149149
end

spec/sideloading_spec.rb

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -123,17 +123,16 @@
123123
end
124124
end
125125

126-
let(:state) { State.create!(name: 'maine') }
127-
let(:genre) { Genre.create!(name: 'horror') }
128-
let(:book1) { Book.create!(title: 'The Shining', genre: genre) }
129-
let(:book2) { Book.create!(title: 'The Stand', genre: genre) }
126+
let!(:state) { State.create!(name: 'maine') }
127+
let!(:genre) { Genre.create!(name: 'horror') }
128+
let!(:book1) { Book.create!(title: 'The Shining', author: author, genre: genre) }
129+
let!(:book2) { Book.create!(title: 'The Stand', author: author, genre: genre) }
130130

131131
let!(:author) do
132132
Author.create! \
133133
first_name: 'Stephen',
134134
last_name: 'King',
135-
state: state,
136-
books: [book1, book2]
135+
state: state
137136
end
138137

139138
def json

0 commit comments

Comments
 (0)