Cleanup

* Correctly separate gem dependencies and Gemfile
* Omit unneeded dependencies
* Remove dependency on nested_attribute_reassignable
* Remove dummy rails app, replace with better test structure

Author: Lee Richmond

.ruby-version

@@ -0,0 +1 @@
+2.3.0

Gemfile

@@ -1,5 +1,12 @@
-source "http://artprod.dev.bloomberg.com/artifactory/api/gems/bb-ruby-repos/"
+source "http://artprod.dev.bloomberg.com/artifactory/api/gems/rubygems/"
 
 # Specify your gem's dependencies in jsonapi_compliable.gemspec
 gemspec
 gem 'active_model_serializers', git: 'https://github.com/richmolj/active_model_serializers.git'
+
+group :test do
+  gem 'guard'
+  gem 'guard-rspec'
+  gem 'pry'
+  gem 'pry-byebug'
+end

jsonapi_compliable.gemspec

@@ -6,8 +6,8 @@ require 'jsonapi_compliable/version'
 Gem::Specification.new do |spec|
   spec.name          = "jsonapi_compliable"
   spec.version       = JsonapiCompliable::VERSION
-  spec.authors       = ["Venkata Pasupuleti"]
-  spec.email         = ["[email protected]"]
+  spec.authors       = ["Lee Richmond", "Venkata Pasupuleti"]
+  spec.email         = ["[email protected]", "[email protected]"]
 
   spec.summary       = %q{JSON Compliable serializer for action controller}
   spec.license       = "MIT"
@@ -17,23 +17,17 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "rails"
-  spec.add_dependency "jsonapi"
-  spec.add_development_dependency "pry"
-  spec.add_development_dependency "pry-byebug"
+  spec.add_dependency "rails", ['>= 4.1', '< 6']
+  spec.add_dependency "jsonapi", '~> 0.1.1.beta2'
+  spec.add_dependency "active_model_serializers", "~> 0.10"
+  spec.add_dependency "jsonapi_ams_extensions", "~> 0.1"
+
   spec.add_development_dependency "kaminari"
   spec.add_development_dependency "active_model_serializers"
-  spec.add_development_dependency "nested_attribute_reassignable"
   spec.add_development_dependency "jsonapi_spec_helpers"
   spec.add_development_dependency "bundler", "~> 1.12"
   spec.add_development_dependency "rake", "~> 10.0"
-  spec.add_development_dependency "rspec"
   spec.add_development_dependency "rspec-rails"
-  spec.add_development_dependency "byebug"
-  spec.add_development_dependency "guard"
   spec.add_development_dependency "sqlite3"
-  spec.add_development_dependency "pg"
-  spec.add_development_dependency "factory_girl"
-  spec.add_development_dependency "guard-rspec"
   spec.add_development_dependency "database_cleaner"
 end

lib/jsonapi_compliable.rb

@@ -1,8 +1,13 @@
+require 'active_model_serializers'
+require 'jsonapi'
+require 'jsonapi_ams_extensions'
+
 require "jsonapi_compliable/version"
 
 module JSONAPICompliable
   autoload :Base,           'jsonapi_compliable/base'
   autoload :Deserializable, 'jsonapi_compliable/deserializable'
+
   def self.included(klass)
     klass.instance_eval do
       include Base

lib/jsonapi_compliable/deserializable.rb

@@ -114,7 +114,7 @@ def parse_has_many(payloads)
     def deserialize_jsonapi!
       self.raw_params = self.params.deep_dup
       self.params = ActionController::Parameters
-      .new(Deserialization.new(params.to_unsafe_h).deserialize)
+        .new(Deserialization.new(params.to_unsafe_h).deserialize)
     end
   end
 end