Skip to content

Commit 9371d1d

Browse files
beaubyrichmolj
authored andcommitted
Upgrade jsonapi-serializable and jsonapi-rails dependencies. (#49)
Upgrade jsonapi-serializable and jsonapi-rails dependencies.
1 parent 09f9584 commit 9371d1d

File tree

9 files changed

+20
-13
lines changed

9 files changed

+20
-13
lines changed

Appraisals

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
appraise "rails-4" do
22
gem "rails", "~> 4.1"
3-
gem 'jsonapi-rails', '~> 0.2.0', require: 'jsonapi/rails'
3+
gem 'jsonapi-rails', '~> 0.3.1', require: 'jsonapi/rails'
44
gem 'rspec-rails'
55
end
66

77
appraise "rails-5" do
88
gem "rails", "~> 5.0"
9-
gem 'jsonapi-rails', '~> 0.2.0', require: 'jsonapi/rails'
9+
gem 'jsonapi-rails', '~> 0.3.1', require: 'jsonapi/rails'
1010
gem 'rspec-rails'
1111
end

gemfiles/rails_4.gemfile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,15 @@
33
source "https://rubygems.org"
44

55
gem "rails", "~> 4.1"
6-
gem "jsonapi-rails", "~> 0.2.0", :require => "jsonapi/rails"
6+
gem "jsonapi-rails", "~> 0.3.1", require: "jsonapi/rails"
77
gem "rspec-rails"
88

99
group :test do
1010
gem "pry"
11-
gem "pry-byebug", :platform => [:mri]
11+
gem "pry-byebug", platform: [:mri]
1212
gem "appraisal"
1313
gem "guard"
1414
gem "guard-rspec"
1515
end
1616

17-
gemspec :path => "../"
17+
gemspec path: "../"

gemfiles/rails_5.gemfile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,15 @@
33
source "https://rubygems.org"
44

55
gem "rails", "~> 5.0"
6-
gem "jsonapi-rails", "~> 0.2.0", :require => "jsonapi/rails"
6+
gem "jsonapi-rails", "~> 0.3.1", require: "jsonapi/rails"
77
gem "rspec-rails"
88

99
group :test do
1010
gem "pry"
11-
gem "pry-byebug", :platform => [:mri]
11+
gem "pry-byebug", platform: [:mri]
1212
gem "appraisal"
1313
gem "guard"
1414
gem "guard-rspec"
1515
end
1616

17-
gemspec :path => "../"
17+
gemspec path: "../"

jsonapi_compliable.gemspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ Gem::Specification.new do |spec|
1818
spec.require_paths = ["lib"]
1919

2020
# Pinning this version until backwards-incompatibility is addressed
21-
spec.add_dependency 'jsonapi-serializable', '~> 0.2.0'
21+
spec.add_dependency 'jsonapi-serializable', '~> 0.3.0'
2222

2323
spec.add_development_dependency "activerecord", ['>= 4.1', '< 6']
2424
spec.add_development_dependency "kaminari", '~> 0.17'

lib/jsonapi_compliable/base.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -290,7 +290,7 @@ def force_includes?
290290

291291
def perform_render_jsonapi(opts)
292292
# TODO(beauby): Reuse renderer.
293-
JSONAPI::Serializable::SuccessRenderer.new
293+
JSONAPI::Serializable::Renderer.new
294294
.render(opts.delete(:jsonapi), opts).to_json
295295
end
296296

lib/jsonapi_compliable/util/render_options.rb

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,14 @@ class RenderOptions
66
def self.generate(object, query_hash, overrides = {})
77
resolved = object.respond_to?(:resolve) ? object.resolve : object
88

9+
inferrer = ::Hash.new do |h, k|
10+
names = k.to_s.split('::')
11+
klass = names.pop
12+
h[k] = [*names, "Serializable#{klass}"].join('::').safe_constantize
13+
end
14+
915
options = {}
16+
options[:class] = inferrer
1017
options[:include] = query_hash[:include]
1118
options[:jsonapi] = resolved
1219
options[:fields] = query_hash[:fields]

spec/extra_fields_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ def include_foo!
3636
end
3737

3838
let(:json) do
39-
render(scope.resolve, class: SerializableTestExtraFields)
39+
render(scope.resolve, class: { Author: SerializableTestExtraFields })
4040
end
4141

4242
it 'does not include extra fields when not requested' do

spec/fields_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ def admin?
2323
let!(:author) { Author.create!(first_name: 'Stephen', last_name: 'King') }
2424

2525
def json
26-
render(scope.resolve, class: SerializableTestFields)
26+
render(scope.resolve, class: { Author: SerializableTestFields })
2727
end
2828

2929
it 'does not limit without fields param' do

spec/support/scope_helper.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ def render(object, opts = {})
1717
opts[:expose] = { context: resource.context }
1818
opts = JsonapiCompliable::Util::RenderOptions.generate(object, query.to_hash[:authors], opts)
1919
resolved = opts.delete(:jsonapi)
20-
raw_json = JSONAPI::Serializable::SuccessRenderer.new.render(resolved, opts).to_json
20+
raw_json = JSONAPI::Serializable::Renderer.new.render(resolved, opts).to_json
2121
JSON.parse(raw_json)
2222
end
2323
end

0 commit comments

Comments
 (0)