Fix sidepost validation silently failing (#140)

* Fix sidepost validation silently failing

Sidepost Child A and Child B on Parent, (method: ‘update’)

If Child A is invalid and Child B is valid I get 200 and the fully patched response for all models, although Child A will not in fact be persisted.

If I remove Child B (the valid one) and sidepost again I get the expected 422 and an errors hash.

This fix is copied from graphiti-api/graphiti#38

* Add specs

From https://github.com/graphiti-api/graphiti/blob/39913b107d6a0956ba10f5abd6d31018b6df91f4/spec/integration/rails/persistence_spec.rb#L395

Author: Seosamh Cahill

lib/jsonapi_compliable/util/validation_response.rb

@@ -45,26 +45,28 @@ def valid_object?(object)
   end
 
   def all_valid?(model, deserialized_params)
-    valid = true
-    return false unless valid_object?(model)
+    checks = []
+    checks << valid_object?(model)
     deserialized_params.each_pair do |name, payload|
       if payload.is_a?(Array)
         related_objects = model.send(name)
-        related_objects.each do |r|
+        related_objects.each_with_index do |r, index|
           valid = valid_object?(r)
+          checks << valid
 
           if valid
-            valid = all_valid?(r, deserialized_params[:relationships] || {})
+            checks << all_valid?(r, payload[index][:relationships] || {})
           end
         end
       else
         related_object = model.send(name)
         valid = valid_object?(related_object)
+        checks << valid
         if valid
-          valid = all_valid?(related_object, deserialized_params[:relationships] || {})
+          checks << all_valid?(related_object, payload[:relationships] || {})
         end
       end
     end
-    valid
+    checks.all? { |c| c == true }
   end
 end

spec/integration/rails/persistence_spec.rb

@@ -26,7 +26,7 @@ def create
             errors: {
               employee: employee.errors,
               positions: employee.positions.map(&:errors),
-              departments: employee.positions.map(&:department).map(&:errors)
+              departments: employee.positions.map(&:department).compact.map(&:errors)
             }
           }
         end
@@ -509,6 +509,52 @@ def do_put(id)
         expect(positions[1].title).to eq('manager')
         expect(department.name).to eq('safety')
       end
+      
+      context 'when a has_many relationship has validation error' do
+        around do |e|
+          begin
+            Position.validates :title, presence: true
+            e.run
+          ensure
+            Position.clear_validators!
+          end
+        end
+
+        before do
+          payload[:included][0][:attributes].delete(:title)
+        end
+
+        it 'rolls back the entire transaction' do
+          expect {
+            do_post
+          }.to_not change { Employee.count+Position.count+Department.count }
+          expect(json['errors']['positions'])
+            .to eq([{ 'title' => ["can't be blank"] }, {}])
+        end
+      end
+
+      context 'when a belongs_to relationship has a validation error' do
+        around do |e|
+          begin
+            Department.validates :name, presence: true
+            e.run
+          ensure
+            Department.clear_validators!
+          end
+        end
+
+        before do
+          payload[:included][1][:attributes].delete(:name)
+        end
+
+        it 'rolls back the entire transaction' do
+          expect {
+            do_post
+          }.to_not change { Employee.count+Position.count+Department.count }
+          expect(json['errors']['departments'])
+            .to eq([{ 'name' => ["can't be blank"] }])
+        end
+      end
 
       context 'when associating to an existing record' do
         let!(:classification) { Classification.create!(description: 'senior') }