Move to jsonapi-serializable

Author: Lee Richmond

jsonapi_errorable.gemspec

@@ -19,7 +19,7 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
 
   spec.add_dependency 'rails', [">= 4.1", "< 6"]
-  spec.add_dependency 'active_model_serializers', '~> 0.10'
+  spec.add_dependency 'jsonapi-serializable', '~> 0.1'
 
   spec.add_development_dependency "bundler", "~> 1.11"
   spec.add_development_dependency "rake", "~> 10.0"

lib/jsonapi_errorable.rb

@@ -1,8 +1,9 @@
-require 'active_model_serializers'
+require 'jsonapi/serializable'
+
 require 'jsonapi_errorable/version'
 require 'jsonapi_errorable/exception_handler'
 require 'jsonapi_errorable/validatable'
-require 'jsonapi_errorable/serializers/validation_serializer'
+require 'jsonapi_errorable/serializers/serializable_validation'
 
 module JsonapiErrorable
   def self.included(klass)

lib/jsonapi_errorable/serializers/validation_serializer.rb renamed to lib/jsonapi_errorable/serializers/serializable_validation.rb

@@ -1,36 +1,32 @@
 module JsonapiErrorable
   module Serializers
-    class ValidationSerializer < ActiveModel::Serializer
-      attribute :errors
+    class SerializableValidation < JSONAPI::Serializable::Resource
+      type :validation_errors
 
-      def errors
-        object.errors.to_hash.map do |attribute, messages|
+      attribute :errors do
+        @object.errors.to_hash.map do |attribute, messages|
           messages.map do |message|
             {
               code:   'unprocessable_entity',
               status: '422',
               title: 'Validation Error',
               detail: "#{attribute.capitalize} #{message}",
-              source: { pointer: pointer_for(object, attribute) },
+              source: { pointer: pointer_for(@object, attribute) },
               meta:   { attribute: attribute, message: message }
             }
           end
         end.flatten
       end
 
-      def activerecord?
-        object.is_a?(ActiveRecord::Base)
-      end
-
       def relationship?(name)
         return false unless activerecord?
 
-        relation_names = object.class.reflect_on_all_associations.map(&:name)
+        relation_names = @object.class.reflect_on_all_associations.map(&:name)
         relation_names.include?(name)
       end
 
       def attribute?(name)
-        object.respond_to?(name)
+        @object.respond_to?(name)
       end
 
       private
@@ -45,6 +41,10 @@ def pointer_for(object, name)
           "/data/relationships/#{name}"
         end
       end
+
+      def activerecord?
+        object.is_a?(ActiveRecord::Base)
+      end
     end
   end
 end

lib/jsonapi_errorable/validatable.rb

@@ -4,7 +4,7 @@ def render_errors_for(record)
       render \
         json: record,
         status: :unprocessable_entity,
-        serializer: Serializers::ValidationSerializer,
+        serializer: Serializers::SerializableValidation,
         adapter: :attributes
     end
   end

spec/serializers/validation_serializer_spec.rb renamed to spec/serializers/serializable_validation_spec.rb

@@ -1,10 +1,10 @@
 require 'spec_helper'
 
-RSpec.describe JsonapiErrorable::Serializers::ValidationSerializer do
+RSpec.describe JsonapiErrorable::Serializers::SerializableValidation do
   let(:errors_hash) { { username: ["can't be blank"] } }
 
-  let(:object) { double.as_null_object }
-  let(:instance) { described_class.new(object) }
+  let(:object) { double(id: 123).as_null_object }
+  let(:instance) { described_class.new(object: object) }
 
   before do
     allow(instance).to receive(:activerecord?) { true }
@@ -15,7 +15,7 @@
   end
 
   describe '#errors' do
-    subject { instance.errors }
+    subject { instance.as_jsonapi[:attributes][:errors] }
 
     before do
       allow(object).to receive(:respond_to?).with(:username) { true }

spec/spec_helper.rb

@@ -8,6 +8,7 @@
 require 'jsonapi_errorable'
 
 require File.expand_path("../support/basic_rails_app.rb",  __FILE__)
+require "action_controller/railtie"
 require 'rspec/rails'
 Rails.application = BasicRailsApp.generate