Ensure unknown relations are not set

Author: Lee Richmond

src/util/deserialize.ts

@@ -53,18 +53,25 @@ class Deserializer {
   }
 
   _processRelationships(instance, relationships) {
-    for (let key in relationships) {
-      let relationData = relationships[key].data;
-      if(!relationData) continue; // only links, empty, etc
-
+    this._iterateValidRelationships(instance, relationships, (relationName, relationData) => {
       if (Array.isArray(relationData)) {
         for (let datum of relationData) {
           let relatedRecord = this.deserialize(datum, true);
-          instance[key].push(relatedRecord);
+          instance[relationName].push(relatedRecord);
         }
       } else {
         let relatedRecord = this.deserialize(relationData, true);
-        instance[key] = relatedRecord;
+        instance[relationName] = relatedRecord;
+      }
+    });
+  }
+
+  _iterateValidRelationships(instance, relationships, callback) {
+    for (let key in relationships) {
+      if (instance.klass.attributeList.indexOf(key) >= 0) {
+        let relationData = relationships[key].data;
+        if(!relationData) continue; // only links, empty, etc
+        callback(key, relationData);
       }
     }
   }

test/unit/model-test.ts

@@ -17,6 +17,12 @@ describe('Model', function() {
           unknown: 'adsf'
         },
         relationships: {
+          unknownrelationship: {
+            data: {
+              id: '1',
+              type: 'unknowns'
+            }
+          },
           tags: {},
           genre: {
             data: {
@@ -104,6 +110,11 @@ describe('Model', function() {
       expect(instance).to.not.have.property('unknown');
     });
 
+    it('does not assign unknown relationships', function() {
+      let instance = Model.fromJsonapi(doc.data, doc);
+      expect(instance).to.not.have.property('unknownrelationship');
+    });
+
     it('assigns metadata correctly', function() {
       let instance = Model.fromJsonapi(doc.data, doc);
       expect(instance.__meta__).to.eql({