use patch

Author: jannishuebl

src/model.ts

@@ -783,7 +783,7 @@ export class JSORMBase {
 
     if (this.isPersisted) {
       url = this.klass.url(this.id)
-      verb = "put"
+      verb = "patch"
     }
 
     const json = payload.asJSON()

src/request.ts

@@ -34,12 +34,12 @@ export class Request {
     return this._fetchWithLogging(url, options)
   }
 
-  put(
+  patch(
     url: string,
     payload: JsonapiRequestDoc,
     options: RequestInit
   ): Promise<any> {
-    options.method = "PUT"
+    options.method = "PATCH"
     options.body = JSON.stringify(payload)
 
     return this._fetchWithLogging(url, options)
@@ -98,8 +98,12 @@ export class Request {
     return response
   }
 
-  private async _handleResponse(response: Response, requestOptions: RequestInit) {
-    let wasDelete = requestOptions.method === 'DELETE' &&
+  private async _handleResponse(
+    response: Response,
+    requestOptions: RequestInit
+  ) {
+    let wasDelete =
+      requestOptions.method === "DELETE" &&
       [202, 204, 200].indexOf(response.status) > -1
     if (wasDelete) return
 

test/integration/dirty-tracking.test.ts

@@ -23,22 +23,22 @@ describe("Dirty tracking", () => {
 
   beforeEach(() => {
     let url = "http://example.com/api/v1/authors"
-    fetchMock.post(url, responsePayload('John'))
-    fetchMock.put(`${url}/1`, responsePayload('Jake'))
+    fetchMock.post(url, responsePayload("John"))
+    fetchMock.patch(`${url}/1`, responsePayload("Jake"))
   })
 
   describe("when persisted, dirty, updated", () => {
     it("calls reset()", async () => {
-      let instance = new Author({ firstName: 'John' })
+      let instance = new Author({ firstName: "John" })
       await instance.save()
       expect(instance.isPersisted).to.eq(true)
       expect(instance.isDirty()).to.eq(false)
-      instance.firstName = 'Jake'
+      instance.firstName = "Jake"
       expect(instance.isDirty()).to.eq(true)
       let spy = sinon.spy()
       instance.reset = spy
       await instance.save()
       expect(spy.callCount).to.eq(2)
     })
   })
-})
+})

test/integration/nested-persistence.test.ts

@@ -5,7 +5,7 @@ import { JsonapiRequestDoc, JsonapiResponseDoc } from "../../src/index"
 
 let instance: Author
 let payloads: JsonapiRequestDoc[]
-let putPayloads: JsonapiRequestDoc[]
+let patchPayloads: JsonapiRequestDoc[]
 let deletePayloads: object[]
 let serverResponse: JsonapiResponseDoc
 
@@ -19,10 +19,13 @@ const resetMocks = () => {
     return serverResponse
   })
 
-  fetchMock.put("http://example.com/api/v1/authors/1", (url, payload: any) => {
-    putPayloads.push(JSON.parse(payload.body))
-    return serverResponse
-  })
+  fetchMock.patch(
+    "http://example.com/api/v1/authors/1",
+    (url, payload: any) => {
+      patchPayloads.push(JSON.parse(payload.body))
+      return serverResponse
+    }
+  )
 
   fetchMock.delete(
     "http://example.com/api/v1/authors/1",
@@ -155,7 +158,7 @@ const seedPersistedData = () => {
 describe("nested persistence", () => {
   beforeEach(() => {
     payloads = []
-    putPayloads = []
+    patchPayloads = []
     deletePayloads = []
     instance = new Author({ firstName: "Stephen" })
     serverResponse = {
@@ -290,7 +293,7 @@ describe("nested persistence", () => {
     it("sends the correct payload", async () => {
       await instance.save({ with: { books: "genre" } })
 
-      expect(putPayloads[0]).to.deep.equal(expectedUpdatePayload("update"))
+      expect(patchPayloads[0]).to.deep.equal(expectedUpdatePayload("update"))
     })
   })
 
@@ -304,7 +307,7 @@ describe("nested persistence", () => {
       instance.books[0].genre.isMarkedForDestruction = true
       await instance.save({ with: { books: "genre" } })
 
-      expect(putPayloads[0]).to.deep.equal(expectedUpdatePayload("destroy"))
+      expect(patchPayloads[0]).to.deep.equal(expectedUpdatePayload("destroy"))
     })
 
     it("removes the associated has_many data", async () => {
@@ -332,7 +335,7 @@ describe("nested persistence", () => {
       instance.books[0].genre.isMarkedForDisassociation = true
       await instance.save({ with: { books: "genre" } })
 
-      expect(putPayloads[0]).to.deep.equal(
+      expect(patchPayloads[0]).to.deep.equal(
         expectedUpdatePayload("disassociate")
       )
     })
@@ -352,7 +355,7 @@ describe("nested persistence", () => {
     })
   })
 
-  describe('when sideposting only id', () => {
+  describe("when sideposting only id", () => {
     beforeEach(() => {
       let genre = new Genre({ id: 1 })
       genre.isPersisted = true
@@ -362,8 +365,8 @@ describe("nested persistence", () => {
       instance.books = [book]
     })
 
-    describe('one level', () => {
-      it('adds only resource identifier to the payload', async () => {
+    describe("one level", () => {
+      it("adds only resource identifier to the payload", async () => {
         await instance.save({ with: ["books.id"] })
         expect((<any>payloads)[0].data.relationships).to.deep.eq({
           books: {
@@ -385,8 +388,8 @@ describe("nested persistence", () => {
       })
     })
 
-    describe('2 levels only id', () => {
-      it('sends only relationships, no attributes', async () => {
+    describe("2 levels only id", () => {
+      it("sends only relationships, no attributes", async () => {
         await instance.save({ with: { ["books.id"]: "genre.id" } })
 
         expect((<any>payloads)[0].data.relationships).to.deep.eq({
@@ -422,7 +425,7 @@ describe("nested persistence", () => {
         ])
       })
 
-      describe('when relationships are not dirty', () => {
+      describe("when relationships are not dirty", () => {
         beforeEach(() => {
           instance.books[0].isPersisted = true
           instance.books[0].genre.isPersisted = true
@@ -453,8 +456,8 @@ describe("nested persistence", () => {
       })
     })
 
-    describe('one level id, then full payload', () => {
-      it('should only send relationships in the payload', async () => {
+    describe("one level id, then full payload", () => {
+      it("should only send relationships in the payload", async () => {
         await instance.save({ with: { ["books.id"]: "genre" } })
 
         expect((<any>payloads)[0].included).to.deep.eq([
@@ -480,4 +483,4 @@ describe("nested persistence", () => {
       })
     })
   })
-})
+})

test/integration/persistence.test.ts

@@ -8,13 +8,13 @@ after(() => {
 
 let instance: Person
 let payloads: JsonapiRequestDoc[]
-let putPayloads: JsonapiRequestDoc[]
+let patchPayloads: JsonapiRequestDoc[]
 let deletePayloads: object[]
 let serverResponse: JsonapiResponseDoc
 
 beforeEach(() => {
   payloads = []
-  putPayloads = []
+  patchPayloads = []
   deletePayloads = []
   instance = new Person()
   serverResponse = {
@@ -34,8 +34,8 @@ const resetMocks = () => {
     return serverResponse
   })
 
-  fetchMock.put("http://example.com/api/v1/people/1", (url, payload: any) => {
-    putPayloads.push(JSON.parse(payload.body))
+  fetchMock.patch("http://example.com/api/v1/people/1", (url, payload: any) => {
+    patchPayloads.push(JSON.parse(payload.body))
     return serverResponse
   })
 
@@ -75,7 +75,7 @@ describe("Model persistence", () => {
         instance.firstName = "Joe"
         await instance.save()
 
-        expect(putPayloads[0]).to.deep.equal({
+        expect(patchPayloads[0]).to.deep.equal({
           data: {
             id: "1",
             type: "people",
@@ -104,7 +104,7 @@ describe("Model persistence", () => {
         it("does not send attributes to the server", async () => {
           await instance.save()
 
-          expect(putPayloads[0]).to.deep.equal({
+          expect(patchPayloads[0]).to.deep.equal({
             data: {
               id: "1",
               type: "people"
@@ -274,15 +274,14 @@ describe("Model persistence", () => {
         resetMocks()
       })
 
-      it('does not blow up', async () => {
+      it("does not blow up", async () => {
         expect(instance.isPersisted).to.eq(true)
         await instance.destroy()
 
         expect(instance.isPersisted).to.eq(false)
       })
     })
 
-
     describe("when the server returns 202 accepted", () => {
       beforeEach(() => {
         fetchMock.restore()
@@ -297,7 +296,7 @@ describe("Model persistence", () => {
         resetMocks()
       })
 
-      it('does not blow up', async () => {
+      it("does not blow up", async () => {
         expect(instance.isPersisted).to.eq(true)
         await instance.destroy()