Merge pull request #25 from willsoto/enumberable-properties

[Proposal] Make attributes enumerable

Author: richmolj

src/attribute.ts

@@ -51,11 +51,11 @@ export default class Attribute {
   }
 
   // This returns the getters/setters for use on the *model*
-  descriptor() {
+  descriptor(): PropertyDescriptor {
     let attr = this;
 
     return {
-      writeable: true,
+      enumerable: true,
       get() : any {
         return attr.getter(this);
       },

test/unit/attributes-test.ts

@@ -47,6 +47,24 @@ describe('Model attributes', function() {
     expect(author.relationships['books']).to.deep.eq([])
   });
 
+  it('has enumerable properties', function() {
+    let person = new Person();
+    let keys = Object.keys(person);
+
+    expect(keys).to.include('firstName');
+    expect(keys).to.include('lastName');
+  });
+
+  it('has enumerable properties even when subclassing', function() {
+    class BadPerson extends Person {}
+
+    let badPerson = new BadPerson();
+    let keys = Object.keys(badPerson);
+
+    expect(keys).to.include('firstName');
+    expect(keys).to.include('lastName');
+  });
+
   // Without this behavior, the API could add a backwards-compatible field,
   // and this object might blow up.
   describe('when passed an invalid attribute in constructor', function() {

test/unit/relationships-test.ts

@@ -33,4 +33,12 @@ describe('Model relationships', function() {
     let genre = new Genre();
     expect(genre.authors.length).to.eql(0);
   });
+
+  it('has enumerable properties', function() {
+    let genre = new Genre({ name: 'Horror' });
+    let author = new Author({ genre: genre });
+    let keys = Object.keys(author);
+
+    expect(keys).to.include('genre');
+  });
 });