Fix: Add double-click support for persistent note tabs (#127)

* Fix: Add double-click support for persistent note tabs

- Implements double-click detection (300ms threshold) in tree view
- Single-click: Opens notes in preview mode (italicized tabs)
- Double-click: Opens notes in persistent mode (normal tabs)
- Matches standard VS Code file explorer behavior

Fixes issue where double-clicking notes had no effect and all notes
opened in preview mode only.

* Refactor: Improve double-click detection with IIFE closure

Code review improvements:
- Encapsulate state variables (lastClickedFile, lastClickTime) in IIFE closure
- Change 'let' to 'const' for openNote disposable to prevent reassignment
- Improves maintainability by avoiding scope pollution
- Keeps state tightly coupled with command handler

This refactoring maintains the same functionality while improving code quality.

---------

Co-authored-by: Claude <[email protected]>

Author: jsonify

src/extension.ts

@@ -827,11 +827,31 @@ export function activate(context: vscode.ExtensionContext) {
         }
     });
 
-    // Command to open note from tree
-    let openNote = vscode.commands.registerCommand('noted.openNote', async (filePath: string) => {
-        const document = await vscode.workspace.openTextDocument(filePath);
-        await vscode.window.showTextDocument(document, { preserveFocus: true });
-    });
+    // Command to open note from tree, with double-click detection
+    const openNote = vscode.commands.registerCommand('noted.openNote', (() => {
+        let lastClickedFile: string | null = null;
+        let lastClickTime: number = 0;
+        const DOUBLE_CLICK_THRESHOLD = 300; // milliseconds
+
+        return async (filePath: string) => {
+            const now = Date.now();
+            const timeSinceLastClick = now - lastClickTime;
+            const isDoubleClick = lastClickedFile === filePath && timeSinceLastClick < DOUBLE_CLICK_THRESHOLD;
+
+            // Update tracking variables for the next click
+            lastClickedFile = filePath;
+            lastClickTime = now;
+
+            const document = await vscode.workspace.openTextDocument(filePath);
+
+            // Open in persistent mode (non-preview) if double-clicked, otherwise open in preview mode
+            if (isDoubleClick) {
+                await vscode.window.showTextDocument(document, { preview: false, preserveFocus: false });
+            } else {
+                await vscode.window.showTextDocument(document, { preview: true, preserveFocus: true });
+            }
+        };
+    })());
 
     // Command to create a note from a link (used in hover preview for broken links)
     let createNoteFromLink = vscode.commands.registerCommand('noted.createNoteFromLink', async (linkText: string) => {