Commit 6b25087
Fix extension release notes showing old version (#126)
* fix: Update changelog fallback to show v1.43.14 features
Fixed issue where extension changelog was showing old v1.43.12 content
instead of the latest v1.43.14 features for users installing from
marketplace.
## Problem
When users install the extension from VS Code marketplace, they don't
have the git repository, so the changelog system falls back to hardcoded
content. This fallback was still showing v1.43.12 (PR #123) instead of
v1.43.14 (PR #125).
## Solution
Updated getFallbackRelease() function with:
- Version number: 1.43.12 → 1.43.14
- PR number: #123 → #125
- Feature description: Hierarchical note naming and organization
- Added comprehensive feature highlights for the new hierarchical notes system
## Changes
- Updated fallback version in getFallbackRelease() (line 91)
- Updated fallback version in getLatestRelease() (line 60)
- Updated fallback version in showChangelogView() (line 139)
- Replaced PR #123 content with PR #125 hierarchical notes feature details
Users will now see the correct "What's New" content showing the new
hierarchical notes feature when opening the changelog popup.
* refactor: Externalize fallback release data to JSON file
Addressed code review feedback to improve maintainability by moving
hardcoded fallback release information to an external JSON file.
## Changes
**New File: src/version/fallback-release.json**
- Centralized all fallback release data (version, date, title, description, PR info)
- Single source of truth for release information
- Easy to update for future releases
**Updated: src/version/changelogView.ts**
- Import fallback data from JSON file
- Replace all hardcoded version strings with `fallbackReleaseData.version`
- Simplified getFallbackRelease() to just return imported data
- Eliminated duplication across 3 locations (lines 60, 91, 139)
**Configuration Updates:**
- tsconfig.json: Added `resolveJsonModule: true` for JSON imports
- esbuild.js: Added JSON loader configuration
## Benefits
- ✅ No more version string duplication
- ✅ Easier future updates (just edit JSON file)
- ✅ Reduced risk of inconsistencies
- ✅ Better separation of data and code
- ✅ More maintainable codebase
Future releases only need to update the JSON file - no code changes required!
---------
Co-authored-by: Claude <[email protected]>1 parent 37cdb34 commit 6b25087
File tree
4 files changed
+18
-18
lines changed- src/version
4 files changed
+18
-18
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
57 | 57 | | |
58 | 58 | | |
59 | 59 | | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
60 | 64 | | |
61 | 65 | | |
62 | 66 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| 5 | + | |
5 | 6 | | |
6 | 7 | | |
7 | 8 | | |
| |||
57 | 58 | | |
58 | 59 | | |
59 | 60 | | |
60 | | - | |
| 61 | + | |
61 | 62 | | |
62 | 63 | | |
63 | 64 | | |
| |||
85 | 86 | | |
86 | 87 | | |
87 | 88 | | |
| 89 | + | |
88 | 90 | | |
89 | 91 | | |
90 | | - | |
91 | | - | |
92 | | - | |
93 | | - | |
94 | | - | |
95 | | - | |
96 | | - | |
97 | | - | |
98 | | - | |
99 | | - | |
100 | | - | |
101 | | - | |
102 | | - | |
103 | | - | |
104 | | - | |
105 | | - | |
| 92 | + | |
106 | 93 | | |
107 | 94 | | |
108 | 95 | | |
| |||
124 | 111 | | |
125 | 112 | | |
126 | 113 | | |
127 | | - | |
| 114 | + | |
128 | 115 | | |
129 | 116 | | |
130 | 117 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| 15 | + | |
15 | 16 | | |
16 | 17 | | |
17 | 18 | | |
| |||
0 commit comments