test: 💍 add full encoder to roundtrip tests

Author: streamich

src/nfs/v3/__tests__/roundtrip.spec.ts

@@ -2,6 +2,7 @@ import {RmRecordDecoder, RmRecordEncoder} from '../../../rm';
 import {RpcCallMessage, RpcMessageDecoder, RpcMessageEncoder} from '../../../rpc';
 import {Nfsv3Decoder} from '../Nfsv3Decoder';
 import {Nfsv3Encoder} from '../Nfsv3Encoder';
+import {FullNfsv3Encoder} from '../FullNfsv3Encoder';
 import * as msg from '../messages';
 import {nfsv3} from './fixtures';
 
@@ -11,8 +12,9 @@ const rpcDecoder = new RpcMessageDecoder();
 const rpcEncoder = new RpcMessageEncoder();
 const nfsDecoder = new Nfsv3Decoder();
 const nfsEncoder = new Nfsv3Encoder();
+const fullNfsEncoder = new FullNfsv3Encoder();
 
-const assertCallRoundtrip = (hex: string): void => {
+const assertCallRoundtrip = (hex: string, fullEncoder: boolean = false): void => {
   const originalHex = hex.toLowerCase();
   const buffer = Buffer.from(originalHex, 'hex');
   rmDecoder.push(new Uint8Array(buffer));
@@ -23,28 +25,40 @@ const assertCallRoundtrip = (hex: string): void => {
     const rpcMessage = rpcDecoder.decodeMessage(rmRecord);
     if (!(rpcMessage instanceof RpcCallMessage)) throw new Error(`Expected RPC Call message`);
     const nfsRequest = nfsDecoder.decodeMessage(rpcMessage.params!, rpcMessage.proc, true) as msg.Nfsv3Request;
-    const nfsEncoded = nfsEncoder.encodeMessage(nfsRequest, rpcMessage.proc, true);
-    const rpcEncoded = rpcEncoder.encodeCall(
-      rpcMessage.xid,
-      rpcMessage.prog,
-      rpcMessage.vers,
-      rpcMessage.proc,
-      rpcMessage.cred,
-      rpcMessage.verf,
-      nfsEncoded,
-    );
-    const rmEncoded = rmEncoder.encodeRecord(rpcEncoded);
+    let rmEncoded: Uint8Array;
+    if (fullEncoder) {
+      rmEncoded = fullNfsEncoder.encodeCall(
+        rpcMessage.xid,
+        rpcMessage.proc,
+        rpcMessage.cred,
+        rpcMessage.verf,
+        nfsRequest,
+      );
+    } else {
+      const nfsEncoded = nfsEncoder.encodeMessage(nfsRequest, rpcMessage.proc, true);
+      const rpcEncoded = rpcEncoder.encodeCall(
+        rpcMessage.xid,
+        rpcMessage.prog,
+        rpcMessage.vers,
+        rpcMessage.proc,
+        rpcMessage.cred,
+        rpcMessage.verf,
+        nfsEncoded,
+      );
+      rmEncoded = rmEncoder.encodeRecord(rpcEncoded);
+    }
     const encodedHex = Buffer.from(rmEncoded).toString('hex').toLowerCase();
     totalEncodedHex += encodedHex;
   }
   expect(totalEncodedHex).toBe(originalHex);
 };
 
 test('assert roundtrip of Call messages', () => {
-  assertCallRoundtrip(nfsv3.GETATTR.Call[0]);
-  assertCallRoundtrip(nfsv3.GETATTR.Call[0] + nfsv3.ACCESS.Call[0]);
-  assertCallRoundtrip(
-    nfsv3.ACCESS.Call[0] +
+  assertCallRoundtrip(nfsv3.GETATTR.Call[0], false);
+  assertCallRoundtrip(nfsv3.GETATTR.Call[0], true);
+  assertCallRoundtrip(nfsv3.GETATTR.Call[0] + nfsv3.ACCESS.Call[0], false);
+  assertCallRoundtrip(nfsv3.GETATTR.Call[0] + nfsv3.ACCESS.Call[0], true);
+  const stream = nfsv3.ACCESS.Call[0] +
     nfsv3.GETATTR.Call[0] +
     nfsv3.COMMIT.Call[0] +
     nfsv3.RMDIR.Call[0] +
@@ -54,5 +68,7 @@ test('assert roundtrip of Call messages', () => {
     nfsv3.REMOVE.Call[0] +
     nfsv3.CREATE.Call[0] +
     nfsv3.CREATE.Call[0] +
-    nfsv3.LOOKUP.Call[0]);
+    nfsv3.LOOKUP.Call[0];
+  assertCallRoundtrip(stream, false);
+  assertCallRoundtrip(stream, true);
 });