test: 💍 add NFS call roundtrip tests

Author: streamich

src/nfs/v3/__tests__/Nfsv3Decoder.spec.ts

@@ -59,7 +59,6 @@ describe('NFSv3 Decoder with real traffic', () => {
       expect(proc).toBe(Nfsv3Proc.LOOKUP);
       expect(request).toBeInstanceOf(msg.Nfsv3LookupRequest);
       const lookupReq = request as msg.Nfsv3LookupRequest;
-      console.log(lookupReq);
       expect(lookupReq.what.name).toBe('hello');
     });
 

src/nfs/v3/__tests__/roundtrip.spec.ts

@@ -0,0 +1,58 @@
+import {RmRecordDecoder, RmRecordEncoder} from '../../../rm';
+import {RpcCallMessage, RpcMessageDecoder, RpcMessageEncoder} from '../../../rpc';
+import {Nfsv3Decoder} from '../Nfsv3Decoder';
+import {Nfsv3Encoder} from '../Nfsv3Encoder';
+import * as msg from '../messages';
+import {nfsv3} from './fixtures';
+
+const rmDecoder = new RmRecordDecoder();
+const rmEncoder = new RmRecordEncoder();
+const rpcDecoder = new RpcMessageDecoder();
+const rpcEncoder = new RpcMessageEncoder();
+const nfsDecoder = new Nfsv3Decoder();
+const nfsEncoder = new Nfsv3Encoder();
+
+const assertCallRoundtrip = (hex: string): void => {
+  const originalHex = hex.toLowerCase();
+  const buffer = Buffer.from(originalHex, 'hex');
+  rmDecoder.push(new Uint8Array(buffer));
+  let totalEncodedHex = '';
+  while (true) {
+    const rmRecord = rmDecoder.readRecord();
+    if (!rmRecord) break;
+    const rpcMessage = rpcDecoder.decodeMessage(rmRecord);
+    if (!(rpcMessage instanceof RpcCallMessage)) throw new Error(`Expected RPC Call message`);
+    const nfsRequest = nfsDecoder.decodeMessage(rpcMessage.params!, rpcMessage.proc, true) as msg.Nfsv3Request;
+    const nfsEncoded = nfsEncoder.encodeMessage(nfsRequest, rpcMessage.proc, true);
+    const rpcEncoded = rpcEncoder.encodeCall(
+      rpcMessage.xid,
+      rpcMessage.prog,
+      rpcMessage.vers,
+      rpcMessage.proc,
+      rpcMessage.cred,
+      rpcMessage.verf,
+      nfsEncoded,
+    );
+    const rmEncoded = rmEncoder.encodeRecord(rpcEncoded);
+    const encodedHex = Buffer.from(rmEncoded).toString('hex').toLowerCase();
+    totalEncodedHex += encodedHex;
+  }
+  expect(totalEncodedHex).toBe(originalHex);
+};
+
+test('assert roundtrip of Call messages', () => {
+  assertCallRoundtrip(nfsv3.GETATTR.Call[0]);
+  assertCallRoundtrip(nfsv3.GETATTR.Call[0] + nfsv3.ACCESS.Call[0]);
+  assertCallRoundtrip(
+    nfsv3.ACCESS.Call[0] +
+    nfsv3.GETATTR.Call[0] +
+    nfsv3.COMMIT.Call[0] +
+    nfsv3.RMDIR.Call[0] +
+    nfsv3.MKDIR.Call[0] +
+    nfsv3.RMDIR.Call[0] +
+    nfsv3.READDIRPLUS.Call[0] +
+    nfsv3.REMOVE.Call[0] +
+    nfsv3.CREATE.Call[0] +
+    nfsv3.CREATE.Call[0] +
+    nfsv3.LOOKUP.Call[0]);
+});