fix: Fix multiple off implementation

Author: DannyvdSluijs

src/JsonSchema/Constraints/Drafts/Draft06/Draft06Constraint.php

@@ -12,13 +12,13 @@
 
 class Draft06Constraint extends Constraint
 {
-    public function __construct(\JsonSchema\Constraints\Factory $factory = null)
+    public function __construct(?\JsonSchema\Constraints\Factory $factory = null)
     {
 
         parent::__construct(new Factory(
             $factory ? $factory->getSchemaStorage() : new SchemaStorage(),
             $factory ? $factory->getUriRetriever() : new UriRetriever(),
-            $factory ? $factory->getConfig() : Constraint::CHECK_MODE_NORMAL,
+            $factory ? $factory->getConfig() : Constraint::CHECK_MODE_NORMAL
         ));
     }
 

src/JsonSchema/Constraints/Drafts/Draft06/MultipleOfConstraint.php

@@ -29,21 +29,22 @@ public function check(&$value, $schema = null, ?JsonPointer $path = null, $i = n
             return;
         }
 
-        if (fmod($value, $schema->multipleOf) === 0.0 || $this->isMultipleOf((string) $value, (string) $schema->multipleOf)) {
+        if ($this->isMultipleOf($value, $schema->multipleOf)) {
             return;
         }
 
         $this->addError(ConstraintError::MULTIPLE_OF(), $path, ['multipleOf' => $schema->multipleOf, 'found' => $value]);
     }
 
-    private function isMultipleOf(string $value, string $multipleOf): bool
+    private function isMultipleOf($number1, $number2)
     {
-        if (bccomp($multipleOf, '0', 20) === 0) {
-            return false;
-        }
+        $modulus = ($number1 - round($number1 / $number2) * $number2);
+        $precision = 0.0000000001;
 
-        $div = bcdiv($value, $multipleOf, 20);
+        if (-$precision < $modulus && $modulus < $precision) {
+            return true;
+        }
 
-        return bccomp(bcmod($div, '1', 20), '0', 20) === 0;
+        return false;
     }
 }

src/JsonSchema/Constraints/Drafts/Draft06/RefConstraint.php

@@ -0,0 +1,46 @@
+<?php
+
+declare(strict_types=1);
+
+namespace JsonSchema\Constraints\Drafts\Draft06;
+
+use JsonSchema\ConstraintError;
+use JsonSchema\Constraints\ConstraintInterface;
+use JsonSchema\Entity\ErrorBagProxy;
+use JsonSchema\Entity\JsonPointer;
+
+class RefConstraint implements ConstraintInterface
+{
+    use ErrorBagProxy;
+
+    /** @var Factory */
+    private $factory;
+
+    public function __construct(?Factory $factory = null)
+    {
+        $this->factory = $factory ?: new Factory();
+        $this->initialiseErrorBag($this->factory);
+    }
+
+    public function check(&$value, $schema = null, ?JsonPointer $path = null, $i = null): void
+    {
+        if (!property_exists($schema, '$ref')) {
+            return;
+        }
+
+        try {
+            $refSchema = $this->factory->getSchemaStorage()->resolveRefSchema($schema);
+        } catch (\Exception $e) {
+            return;
+        }
+
+        $schemaConstraint = $this->factory->createInstanceFor('schema');
+        $schemaConstraint->check($value, $refSchema, $path, $i);
+
+        if ($schemaConstraint->isValid()) {
+            return;
+        }
+
+        $this->addErrors($schemaConstraint->getErrors());
+    }
+}