fix: create deep copy before checking each sub schema in oneOf when only check_mode_apply_defaults is set

#510

Author: DannyvdSluijs

src/JsonSchema/Constraints/UndefinedConstraint.php

@@ -359,13 +359,13 @@ protected function validateOfProperties(&$value, $schema, JsonPointer $path, $i
             $allErrors = [];
             $matchedSchemas = [];
             $startErrors = $this->getErrors();
-            $coerce = $this->factory->getConfig(self::CHECK_MODE_COERCE_TYPES);
+            $coerceOrDefaults = $this->factory->getConfig(self::CHECK_MODE_COERCE_TYPES | self::CHECK_MODE_APPLY_DEFAULTS);
 
             foreach ($schema->oneOf as $oneOf) {
                 try {
                     $this->errors = [];
 
-                    $oneOfValue = $coerce ? DeepCopy::copyOf($value) : $value;
+                    $oneOfValue = $coerceOrDefaults ? DeepCopy::copyOf($value) : $value;
                     $this->checkUndefined($oneOfValue, $oneOf, $path, $i);
                     if (count($this->getErrors()) === 0) {
                         $matchedSchemas[] = ['schema' => $oneOf, 'value' => $oneOfValue];

tests/Constraints/UndefinedConstraintTest.php

@@ -70,6 +70,56 @@ public function getValidTests(): array
                 ,
                 'checkMode' => Constraint::CHECK_MODE_COERCE_TYPES
             ],
+            'oneOf with apply defaults should not affect value passed to each sub schema (#510)' => [
+                'input' => <<<JSON
+                    {"foo": {"name": "bar"}}
+JSON
+                ,
+                'schema' => <<<JSON
+                    {
+                        "oneOf": [
+                            {
+                                "type": "object",
+                                "properties": {
+                                    "foo": {
+                                        "type": "object",
+                                        "properties": {
+                                            "name": {"enum":["baz"],"default":"baz"},
+                                            "meta": {"enum":["baz"],"default":"baz"}
+                                        }
+                                    }
+                                }
+                            },
+                            {
+                                "type": "object",
+                                "properties": {
+                                    "foo": {
+                                        "type": "object",
+                                        "properties": {
+                                            "name": {"enum":["bar"],"default":"bar"},
+                                            "meta": {"enum":["bar"],"default":"bar"}
+                                        }
+                                    }
+                                }
+                            },
+                            {
+                                "type": "object",
+                                "properties": {
+                                    "foo": {
+                                        "type": "object",
+                                        "properties": {
+                                            "name": {"enum":["zip"],"default":"zip"},
+                                            "meta": {"enum":["zip"],"default":"zip"}
+                                        }
+                                    }
+                                }
+                            }
+                        ]
+                    }
+JSON
+                ,
+                'checkMode' => Constraint::CHECK_MODE_APPLY_DEFAULTS
+            ],
             'anyOf with apply defaults should not affect value passed to each sub schema (#711)' => [
                 'input' => <<<JSON
                     {