refactor: use ::class constant instead of string value

DannyvdSluijs · DannyvdSluijs · commit aa3e0183a9c3 · 2025-06-23T20:57:56.000+02:00
diff --git a/tests/ConstraintErrorTest.php b/tests/ConstraintErrorTest.php
@@ -19,7 +19,7 @@ public function testGetInvalidMessage(): void
     {
         $e = ConstraintError::MISSING_ERROR();
 
-        $this->expectException('\JsonSchema\Exception\InvalidArgumentException');
+        $this->expectException(\JsonSchema\Exception\InvalidArgumentException::class);
         $this->expectExceptionMessage('Missing error message for missingError');
 
         $e->getMessage();
diff --git a/tests/Constraints/SchemaValidationTest.php b/tests/Constraints/SchemaValidationTest.php
@@ -97,15 +97,15 @@ public function testValidCases($schema): void
 
     public function testNonObjectSchema(): void
     {
-        $this->expectException('\JsonSchema\Exception\RuntimeException');
+        $this->expectException(\JsonSchema\Exception\RuntimeException::class);
         $this->expectExceptionMessage('Cannot validate the schema of a non-object');
 
         $this->testValidCases('"notAnObject"');
     }
 
     public function testInvalidSchemaException(): void
     {
-        $this->expectException('\JsonSchema\Exception\InvalidSchemaException');
+        $this->expectException(\JsonSchema\Exception\InvalidSchemaException::class);
         $this->expectExceptionMessage('Schema did not pass validation');
 
         $input = json_decode('{}');
diff --git a/tests/Constraints/TypeTest.php b/tests/Constraints/TypeTest.php
@@ -121,7 +121,7 @@ public function testValidateTypeException(): void
         $data = new \stdClass();
         $schema = json_decode('{"type": "notAValidTypeName"}');
 
-        $this->expectException('JsonSchema\Exception\InvalidArgumentException');
+        $this->expectException(\JsonSchema\Exception\InvalidArgumentException::class);
         $this->expectExceptionMessage('object is an invalid type for notAValidTypeName');
 
         $t->check($data, $schema);
diff --git a/tests/Constraints/ValidationExceptionTest.php b/tests/Constraints/ValidationExceptionTest.php
@@ -14,7 +14,7 @@ class ValidationExceptionTest extends TestCase
     public function testValidationException(): void
     {
         $exception = new ValidationException();
-        $this->assertInstanceOf('\JsonSchema\Exception\ValidationException', $exception);
+        $this->assertInstanceOf(\JsonSchema\Exception\ValidationException::class, $exception);
 
         $checkValue = json_decode('{"propertyOne": "thisIsNotAnObject"}');
         $schema = json_decode('{
@@ -40,7 +40,7 @@ public function testValidationException(): void
             $exception->getMessage()
         );
 
-        $this->expectException('JsonSchema\Exception\ValidationException');
+        $this->expectException(\JsonSchema\Exception\ValidationException::class);
         throw $exception;
     }
 }
diff --git a/tests/Exception/InvalidArgumentExceptionTest.php b/tests/Exception/InvalidArgumentExceptionTest.php
@@ -13,6 +13,6 @@ public function testHierarchy(): void
     {
         $exception = new InvalidArgumentException();
         self::assertInstanceOf('\InvalidArgumentException', $exception);
-        self::assertInstanceOf('\JsonSchema\Exception\ExceptionInterface', $exception);
+        self::assertInstanceOf(\JsonSchema\Exception\ExceptionInterface::class, $exception);
     }
 }
diff --git a/tests/Exception/InvalidSchemaMediaTypeExceptionTest.php b/tests/Exception/InvalidSchemaMediaTypeExceptionTest.php
@@ -13,7 +13,7 @@ public function testHierarchy(): void
     {
         $exception = new InvalidSchemaMediaTypeException();
         self::assertInstanceOf('\RuntimeException', $exception);
-        self::assertInstanceOf('\JsonSchema\Exception\RuntimeException', $exception);
-        self::assertInstanceOf('\JsonSchema\Exception\ExceptionInterface', $exception);
+        self::assertInstanceOf(\JsonSchema\Exception\RuntimeException::class, $exception);
+        self::assertInstanceOf(\JsonSchema\Exception\ExceptionInterface::class, $exception);
     }
 }
diff --git a/tests/Exception/InvalidSourceUriExceptionTest.php b/tests/Exception/InvalidSourceUriExceptionTest.php
@@ -13,7 +13,7 @@ public function testHierarchy(): void
     {
         $exception = new InvalidSourceUriException();
         self::assertInstanceOf('\InvalidArgumentException', $exception);
-        self::assertInstanceOf('\JsonSchema\Exception\InvalidArgumentException', $exception);
-        self::assertInstanceOf('\JsonSchema\Exception\ExceptionInterface', $exception);
+        self::assertInstanceOf(\JsonSchema\Exception\InvalidArgumentException::class, $exception);
+        self::assertInstanceOf(\JsonSchema\Exception\ExceptionInterface::class, $exception);
     }
 }
diff --git a/tests/Exception/JsonDecodingExceptionTest.php b/tests/Exception/JsonDecodingExceptionTest.php
@@ -13,8 +13,8 @@ public function testHierarchy(): void
     {
         $exception = new JsonDecodingException();
         self::assertInstanceOf('\RuntimeException', $exception);
-        self::assertInstanceOf('\JsonSchema\Exception\RuntimeException', $exception);
-        self::assertInstanceOf('\JsonSchema\Exception\ExceptionInterface', $exception);
+        self::assertInstanceOf(\JsonSchema\Exception\RuntimeException::class, $exception);
+        self::assertInstanceOf(\JsonSchema\Exception\ExceptionInterface::class, $exception);
     }
 
     public function testDefaultMessage()
diff --git a/tests/Exception/ResourceNotFoundExceptionTest.php b/tests/Exception/ResourceNotFoundExceptionTest.php
@@ -13,7 +13,7 @@ public function testHierarchy(): void
     {
         $exception = new ResourceNotFoundException();
         self::assertInstanceOf('\RuntimeException', $exception);
-        self::assertInstanceOf('\JsonSchema\Exception\RuntimeException', $exception);
-        self::assertInstanceOf('\JsonSchema\Exception\ExceptionInterface', $exception);
+        self::assertInstanceOf(\JsonSchema\Exception\RuntimeException::class, $exception);
+        self::assertInstanceOf(\JsonSchema\Exception\ExceptionInterface::class, $exception);
     }
 }
diff --git a/tests/Exception/RuntimeExceptionTest.php b/tests/Exception/RuntimeExceptionTest.php
@@ -13,6 +13,6 @@ public function testHierarchy(): void
     {
         $exception = new RuntimeException();
         self::assertInstanceOf('\RuntimeException', $exception);
-        self::assertInstanceOf('\JsonSchema\Exception\ExceptionInterface', $exception);
+        self::assertInstanceOf(\JsonSchema\Exception\ExceptionInterface::class, $exception);
     }
 }
diff --git a/tests/Exception/UnresolvableJsonPointerExceptionTest.php b/tests/Exception/UnresolvableJsonPointerExceptionTest.php
@@ -13,7 +13,7 @@ public function testHierarchy(): void
     {
         $exception = new UnresolvableJsonPointerException();
         self::assertInstanceOf('\InvalidArgumentException', $exception);
-        self::assertInstanceOf('\JsonSchema\Exception\InvalidArgumentException', $exception);
-        self::assertInstanceOf('\JsonSchema\Exception\ExceptionInterface', $exception);
+        self::assertInstanceOf(\JsonSchema\Exception\InvalidArgumentException::class, $exception);
+        self::assertInstanceOf(\JsonSchema\Exception\ExceptionInterface::class, $exception);
     }
 }
diff --git a/tests/Exception/UriResolverExceptionTest.php b/tests/Exception/UriResolverExceptionTest.php
@@ -13,7 +13,7 @@ public function testHierarchy(): void
     {
         $exception = new UriResolverException();
         self::assertInstanceOf('\RuntimeException', $exception);
-        self::assertInstanceOf('\JsonSchema\Exception\RuntimeException', $exception);
-        self::assertInstanceOf('\JsonSchema\Exception\ExceptionInterface', $exception);
+        self::assertInstanceOf(\JsonSchema\Exception\RuntimeException::class, $exception);
+        self::assertInstanceOf(\JsonSchema\Exception\ExceptionInterface::class, $exception);
     }
 }
diff --git a/tests/Iterators/ObjectIteratorTest.php b/tests/Iterators/ObjectIteratorTest.php
@@ -34,7 +34,7 @@ public function testCreate(): void
     {
         $i = new ObjectIterator($this->testObject);
 
-        $this->assertInstanceOf('\JsonSchema\Iterator\ObjectIterator', $i);
+        $this->assertInstanceOf(\JsonSchema\Iterator\ObjectIterator::class, $i);
     }
 
     public function testInitialState(): void
diff --git a/tests/RefTest.php b/tests/RefTest.php
@@ -51,7 +51,7 @@ public function dataRefIgnoresSiblings(): array
                 }',
                 '{"propertyOne": 5}',
                 true,
-                '\JsonSchema\Exception\UnresolvableJsonPointerException'
+                \JsonSchema\Exception\UnresolvableJsonPointerException::class
             ]
         ];
     }
diff --git a/tests/SchemaStorageTest.php b/tests/SchemaStorageTest.php
@@ -16,7 +16,7 @@ public function testResolveRef(): void
         $mainSchema = $this->getMainSchema();
         $mainSchemaPath = 'http://www.example.com/schema.json';
 
-        $uriRetriever = $this->prophesize('JsonSchema\UriRetrieverInterface');
+        $uriRetriever = $this->prophesize(\JsonSchema\UriRetrieverInterface::class);
         $uriRetriever->retrieve($mainSchemaPath)->willReturn($mainSchema)->shouldBeCalled();
 
         $schemaStorage = new SchemaStorage($uriRetriever->reveal());
@@ -50,7 +50,7 @@ public function testSchemaWithLocalAndExternalReferencesWithCircularReference():
         $schema3Path = 'http://www.my-domain.com/schema3.json';
 
         /** @var UriRetriever $uriRetriever */
-        $uriRetriever = $this->prophesize('JsonSchema\UriRetrieverInterface');
+        $uriRetriever = $this->prophesize(\JsonSchema\UriRetrieverInterface::class);
         $uriRetriever->retrieve($mainSchemaPath)->willReturn($mainSchema)->shouldBeCalled();
         $uriRetriever->retrieve($schema2Path)->willReturn($schema2)->shouldBeCalled();
         $uriRetriever->retrieve($schema3Path)->willReturn($schema3)->shouldBeCalled();
@@ -97,13 +97,13 @@ public function testSchemaWithLocalAndExternalReferencesWithCircularReference():
 
     public function testUnresolvableJsonPointExceptionShouldBeThrown(): void
     {
-        $this->expectException('JsonSchema\Exception\UnresolvableJsonPointerException');
+        $this->expectException(\JsonSchema\Exception\UnresolvableJsonPointerException::class);
         $this->expectExceptionMessage('File: http://www.example.com/schema.json is found, but could not resolve fragment: #/definitions/car');
 
         $mainSchema = $this->getInvalidSchema();
         $mainSchemaPath = 'http://www.example.com/schema.json';
 
-        $uriRetriever = $this->prophesize('JsonSchema\UriRetrieverInterface');
+        $uriRetriever = $this->prophesize(\JsonSchema\UriRetrieverInterface::class);
         $uriRetriever->retrieve($mainSchemaPath)
             ->willReturn($mainSchema)
             ->shouldBeCalled();
@@ -114,7 +114,7 @@ public function testUnresolvableJsonPointExceptionShouldBeThrown(): void
 
     public function testResolveRefWithNoAssociatedFileName(): void
     {
-        $this->expectException('JsonSchema\Exception\UnresolvableJsonPointerException');
+        $this->expectException(\JsonSchema\Exception\UnresolvableJsonPointerException::class);
         $this->expectExceptionMessage("Could not resolve fragment '#': no file is defined");
 
         $schemaStorage = new SchemaStorage();
@@ -259,14 +259,14 @@ public function testGetUriRetriever(): void
     {
         $s = new SchemaStorage();
         $s->addSchema('http://json-schema.org/draft-04/schema#');
-        $this->assertInstanceOf('\JsonSchema\Uri\UriRetriever', $s->getUriRetriever());
+        $this->assertInstanceOf(\JsonSchema\Uri\UriRetriever::class, $s->getUriRetriever());
     }
 
     public function testGetUriResolver(): void
     {
         $s = new SchemaStorage();
         $s->addSchema('http://json-schema.org/draft-04/schema#');
-        $this->assertInstanceOf('\JsonSchema\Uri\UriResolver', $s->getUriResolver());
+        $this->assertInstanceOf(\JsonSchema\Uri\UriResolver::class, $s->getUriResolver());
     }
 
     public function testMetaSchemaFixes(): void
@@ -286,7 +286,7 @@ public function testNoDoubleResolve(): void
     {
         $schemaOne = json_decode('{"id": "test/schema", "$ref": "../test2/schema2"}');
 
-        $uriRetriever = $this->prophesize('JsonSchema\UriRetrieverInterface');
+        $uriRetriever = $this->prophesize(\JsonSchema\UriRetrieverInterface::class);
         $uriRetriever->retrieve('test/schema')->willReturn($schemaOne)->shouldBeCalled();
 
         $s = new SchemaStorage($uriRetriever->reveal());
diff --git a/tests/Uri/Retrievers/CurlTest.php b/tests/Uri/Retrievers/CurlTest.php
@@ -21,7 +21,7 @@ public function testRetrieveNonexistantFile(): void
         {
             $c = new Curl();
 
-            $this->expectException('\JsonSchema\Exception\ResourceNotFoundException');
+            $this->expectException(\JsonSchema\Exception\ResourceNotFoundException::class);
             $this->expectExceptionMessage('JSON schema not found');
 
             $c->retrieve(__DIR__ . '/notARealFile');
diff --git a/tests/Uri/UriRetrieverTest.php b/tests/Uri/UriRetrieverTest.php
@@ -29,7 +29,7 @@ private function getRetrieverMock($returnSchema)
             throw new JsonDecodingException($error);
         }
 
-        $retriever = $this->createMock('JsonSchema\Uri\UriRetriever');
+        $retriever = $this->createMock(\JsonSchema\Uri\UriRetriever::class);
 
         $retriever->expects($this->at(0))
                   ->method('retrieve')
@@ -227,7 +227,7 @@ public function testResolveExcessLevelUp(): void
 
     public function testConfirmMediaTypeAcceptsJsonSchemaType(): void
     {
-        $uriRetriever = $this->createMock('JsonSchema\Uri\Retrievers\UriRetrieverInterface');
+        $uriRetriever = $this->createMock(\JsonSchema\Uri\Retrievers\UriRetrieverInterface::class);
         $retriever = new UriRetriever();
 
         $uriRetriever->expects($this->at(0))
@@ -239,7 +239,7 @@ public function testConfirmMediaTypeAcceptsJsonSchemaType(): void
 
     public function testConfirmMediaTypeAcceptsJsonType(): void
     {
-        $uriRetriever = $this->createMock('JsonSchema\Uri\Retrievers\UriRetrieverInterface');
+        $uriRetriever = $this->createMock(\JsonSchema\Uri\Retrievers\UriRetrieverInterface::class);
         $retriever = new UriRetriever();
 
         $uriRetriever->expects($this->at(0))
@@ -251,7 +251,7 @@ public function testConfirmMediaTypeAcceptsJsonType(): void
 
     public function testConfirmMediaTypeThrowsExceptionForUnsupportedTypes(): void
     {
-        $uriRetriever = $this->createMock('JsonSchema\Uri\Retrievers\UriRetrieverInterface');
+        $uriRetriever = $this->createMock(\JsonSchema\Uri\Retrievers\UriRetrieverInterface::class);
         $retriever = new UriRetriever();
         $uriRetriever->expects($this->at(0))
                 ->method('getContentType')
@@ -266,11 +266,11 @@ private function mockRetriever($schema): void
     {
         $retrieverMock = $this->getRetrieverMock($schema);
 
-        $factory = new \ReflectionProperty('JsonSchema\Constraints\BaseConstraint', 'factory');
+        $factory = new \ReflectionProperty(\JsonSchema\Constraints\BaseConstraint::class, 'factory');
         $factory->setAccessible(true);
         $factory = $factory->getValue($this->validator);
 
-        $retriever = new \ReflectionProperty('JsonSchema\Constraints\Factory', 'uriRetriever');
+        $retriever = new \ReflectionProperty(\JsonSchema\Constraints\Factory::class, 'uriRetriever');
         $retriever->setAccessible(true);
         $retriever->setValue($factory, $retrieverMock);
     }
@@ -325,7 +325,7 @@ public function testRetrieveSchemaFromPackage(): void
 
     public function testInvalidContentTypeEndpointsDefault(): void
     {
-        $mock = $this->createMock('JsonSchema\Uri\Retrievers\UriRetrieverInterface');
+        $mock = $this->createMock(\JsonSchema\Uri\Retrievers\UriRetrieverInterface::class);
         $mock->method('getContentType')->willReturn('Application/X-Fake-Type');
         $retriever = new UriRetriever();
 
@@ -335,7 +335,7 @@ public function testInvalidContentTypeEndpointsDefault(): void
 
     public function testInvalidContentTypeEndpointsUnknown(): void
     {
-        $mock = $this->createMock('JsonSchema\Uri\Retrievers\UriRetrieverInterface');
+        $mock = $this->createMock(\JsonSchema\Uri\Retrievers\UriRetrieverInterface::class);
         $mock->method('getContentType')->willReturn('Application/X-Fake-Type');
         $retriever = new UriRetriever();
 
@@ -345,7 +345,7 @@ public function testInvalidContentTypeEndpointsUnknown(): void
 
     public function testInvalidContentTypeEndpointsAdded(): void
     {
-        $mock = $this->createMock('JsonSchema\Uri\Retrievers\UriRetrieverInterface');
+        $mock = $this->createMock(\JsonSchema\Uri\Retrievers\UriRetrieverInterface::class);
         $mock->method('getContentType')->willReturn('Application/X-Fake-Type');
         $retriever = new UriRetriever();
         $retriever->addInvalidContentTypeEndpoint('http://example.com');
@@ -378,7 +378,7 @@ public function testLoadSchemaJSONDecodingException(): void
     {
         $retriever = new UriRetriever();
 
-        $this->expectException('JsonSchema\Exception\JsonDecodingException');
+        $this->expectException(\JsonSchema\Exception\JsonDecodingException::class);
         $this->expectExceptionMessage('JSON syntax is malformed');
 
         $retriever->retrieve('package://tests/fixtures/bad-syntax.json');

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ public function testGetInvalidMessage(): void`
`19`	`19`	`{`
`20`	`20`	`$e = ConstraintError::MISSING_ERROR();`
`21`	`21`
`22`		`- $this->expectException('\JsonSchema\Exception\InvalidArgumentException');`
	`22`	`+ $this->expectException(\JsonSchema\Exception\InvalidArgumentException::class);`
`23`	`23`	`$this->expectExceptionMessage('Missing error message for missingError');`
`24`	`24`
`25`	`25`	`$e->getMessage();`
Original file line number	Diff line number	Diff line change
`@@ -97,15 +97,15 @@ public function testValidCases($schema): void`
`97`	`97`
`98`	`98`	`public function testNonObjectSchema(): void`
`99`	`99`	`{`
`100`		`- $this->expectException('\JsonSchema\Exception\RuntimeException');`
	`100`	`+ $this->expectException(\JsonSchema\Exception\RuntimeException::class);`
`101`	`101`	`$this->expectExceptionMessage('Cannot validate the schema of a non-object');`
`102`	`102`
`103`	`103`	`$this->testValidCases('"notAnObject"');`
`104`	`104`	`}`
`105`	`105`
`106`	`106`	`public function testInvalidSchemaException(): void`
`107`	`107`	`{`
`108`		`- $this->expectException('\JsonSchema\Exception\InvalidSchemaException');`
	`108`	`+ $this->expectException(\JsonSchema\Exception\InvalidSchemaException::class);`
`109`	`109`	`$this->expectExceptionMessage('Schema did not pass validation');`
`110`	`110`
`111`	`111`	`$input = json_decode('{}');`
Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ class ValidationExceptionTest extends TestCase`
`14`	`14`	`public function testValidationException(): void`
`15`	`15`	`{`
`16`	`16`	`$exception = new ValidationException();`
`17`		`- $this->assertInstanceOf('\JsonSchema\Exception\ValidationException', $exception);`
	`17`	`+ $this->assertInstanceOf(\JsonSchema\Exception\ValidationException::class, $exception);`
`18`	`18`
`19`	`19`	`$checkValue = json_decode('{"propertyOne": "thisIsNotAnObject"}');`
`20`	`20`	`$schema = json_decode('{`
`@@ -40,7 +40,7 @@ public function testValidationException(): void`
`40`	`40`	`$exception->getMessage()`
`41`	`41`	`);`
`42`	`42`
`43`		`- $this->expectException('JsonSchema\Exception\ValidationException');`
	`43`	`+ $this->expectException(\JsonSchema\Exception\ValidationException::class);`
`44`	`44`	`throw $exception;`
`45`	`45`	`}`
`46`	`46`	`}`
Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,6 @@ public function testHierarchy(): void`
`13`	`13`	`{`
`14`	`14`	`$exception = new InvalidArgumentException();`
`15`	`15`	`self::assertInstanceOf('\InvalidArgumentException', $exception);`
`16`		`- self::assertInstanceOf('\JsonSchema\Exception\ExceptionInterface', $exception);`
	`16`	`+ self::assertInstanceOf(\JsonSchema\Exception\ExceptionInterface::class, $exception);`
`17`	`17`	`}`
`18`	`18`	`}`
Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@ public function testHierarchy(): void`
`13`	`13`	`{`
`14`	`14`	`$exception = new InvalidSchemaMediaTypeException();`
`15`	`15`	`self::assertInstanceOf('\RuntimeException', $exception);`
`16`		`- self::assertInstanceOf('\JsonSchema\Exception\RuntimeException', $exception);`
`17`		`- self::assertInstanceOf('\JsonSchema\Exception\ExceptionInterface', $exception);`
	`16`	`+ self::assertInstanceOf(\JsonSchema\Exception\RuntimeException::class, $exception);`
	`17`	`+ self::assertInstanceOf(\JsonSchema\Exception\ExceptionInterface::class, $exception);`
`18`	`18`	`}`
`19`	`19`	`}`
Original file line number	Diff line number	Diff line change
`@@ -13,8 +13,8 @@ public function testHierarchy(): void`
`13`	`13`	`{`
`14`	`14`	`$exception = new JsonDecodingException();`
`15`	`15`	`self::assertInstanceOf('\RuntimeException', $exception);`
`16`		`- self::assertInstanceOf('\JsonSchema\Exception\RuntimeException', $exception);`
`17`		`- self::assertInstanceOf('\JsonSchema\Exception\ExceptionInterface', $exception);`
	`16`	`+ self::assertInstanceOf(\JsonSchema\Exception\RuntimeException::class, $exception);`
	`17`	`+ self::assertInstanceOf(\JsonSchema\Exception\ExceptionInterface::class, $exception);`
`18`	`18`	`}`
`19`	`19`
`20`	`20`	`public function testDefaultMessage()`