fix: resolve phpstan errors

Author: DannyvdSluijs

phpstan-baseline.neon

@@ -641,7 +641,7 @@ parameters:
 			path: src/JsonSchema/SchemaStorage.php
 
 		-
-			message: "#^Call to function is_array\\(\\) with object will always evaluate to false\\.$#"
+			message: "#^Call to function is_array\\(\\) with bool|object will always evaluate to false\\.$#"
 			count: 1
 			path: src/JsonSchema/SchemaStorage.php
 

src/JsonSchema/Constraints/Factory.php

@@ -50,6 +50,7 @@ class Factory
      */
     protected $errorContext = Validator::ERROR_DOCUMENT_VALIDATION;
 
+    /** @var string */
     private $defaultDialect = 'http://json-schema.org/draft-06/schema#';
 
     /**

src/JsonSchema/Constraints/UndefinedConstraint.php

@@ -239,12 +239,19 @@ protected function applyDefaultValues(&$value, $schema, $path): void
             return;
         }
 
+        if (is_bool($schema)) {
+            return;
+        }
+
         // apply defaults if appropriate
         $requiredOnly = (bool) $this->factory->getConfig(self::CHECK_MODE_ONLY_REQUIRED_DEFAULTS);
         if (isset($schema->properties) && LooseTypeCheck::isObject($value)) {
             // $value is an object or assoc array, and properties are defined - treat as an object
             foreach ($schema->properties as $currentProperty => $propertyDefinition) {
                 $propertyDefinition = $this->factory->getSchemaStorage()->resolveRefSchema($propertyDefinition);
+                if (is_bool($propertyDefinition)) {
+                    continue;
+                }
                 if (
                     !LooseTypeCheck::propertyExists($value, $currentProperty)
                     && property_exists($propertyDefinition, 'default')
@@ -269,6 +276,10 @@ protected function applyDefaultValues(&$value, $schema, $path): void
             // $value is an array, and items are defined - treat as plain array
             foreach ($items as $currentItem => $itemDefinition) {
                 $itemDefinition = $this->factory->getSchemaStorage()->resolveRefSchema($itemDefinition);
+                if (is_bool($itemDefinition)) {
+                    continue;
+                }
+
                 if (
                     !array_key_exists($currentItem, $value)
                     && property_exists($itemDefinition, 'default')

src/JsonSchema/Entity/ErrorBag.php

@@ -76,9 +76,9 @@ public function addError(ConstraintError $constraint, ?JsonPointer $path = null,
         if ($this->factory->getConfig(Constraint::CHECK_MODE_EXCEPTIONS)) {
             throw new ValidationException(sprintf('Error validating %s: %s', $error['pointer'], $error['message']));
         }
-
         $this->errors[] = $error;
-        $this->errorMask |= $error['context'];
+        /** @see https://github.com/phpstan/phpstan/issues/9384 */
+        $this->errorMask |= $error['context']; // @phpstan-ignore assign.propertyType
     }
 
     /** @param ErrorList $errors */

src/JsonSchema/SchemaStorage.php

@@ -182,7 +182,7 @@ public function resolveRefSchema($refSchema, $resolveStack = [])
         }
 
         if (is_object($refSchema) && array_keys(get_object_vars($refSchema)) === ['']) {
-            $refSchema = $refSchema->{''};
+            $refSchema = get_object_vars($refSchema)[''];
         }
 
         return $refSchema;

src/JsonSchema/SchemaStorageInterface.php

@@ -9,21 +9,21 @@ interface SchemaStorageInterface
     /**
      * Adds schema with given identifier
      *
-     * @param object $schema
+     * @param object|bool $schema
      */
     public function addSchema(string $id, $schema = null): void;
 
     /**
      * Returns schema for given identifier, or null if it does not exist
      *
-     * @return object
+     * @return object|bool
      */
     public function getSchema(string $id);
 
     /**
      * Returns schema for given reference with all sub-references resolved
      *
-     * @return object
+     * @return object|bool
      */
     public function resolveRef(string $ref);
 
@@ -32,7 +32,7 @@ public function resolveRef(string $ref);
      *
      * @param mixed $refSchema
      *
-     * @return object
+     * @return object|bool
      */
     public function resolveRefSchema($refSchema);
 }