[2022-06-16]: Secret scanning dry runs on custom pattern edits - [Public Beta] (github#28390)

Author: felicitymay

content/code-security/secret-scanning/defining-custom-patterns-for-secret-scanning.md

@@ -28,9 +28,9 @@ topics:
 You can define custom patterns to identify secrets that are not detected by the default patterns supported by {% data variables.product.prodname_secret_scanning %}. For example, you might have a secret pattern that is internal to your organization. For details of the supported secrets and service providers, see "[{% data variables.product.prodname_secret_scanning_caps %} patterns](/code-security/secret-scanning/secret-scanning-patterns)."
 
 You can define custom patterns for your enterprise, organization, or repository. {% data variables.product.prodname_secret_scanning_caps %} supports up to 
-{%- ifversion fpt or ghec or ghes > 3.3 %} 500 custom patterns for each organization or enterprise account, and up to 100 custom patterns per repository.
-{%- elsif ghes = 3.3 %} 100 custom patterns for each organization or enterprise account, and 20 per repository.
-{%- else %} 20 custom patterns for each organization or enterprise account, and per repository.
+{%- ifversion fpt or ghec or ghes > 3.3 or ghae-issue-7297 %} 500 custom patterns for each organization or enterprise account, and up to 100 custom patterns per repository.
+{%- elsif ghes = 3.2 %} 20 custom patterns for each organization or enterprise account, and per repository.
+{%- else %} 100 custom patterns for each organization or enterprise account, and 20 per repository.
 {%- endif %}
 
 {% ifversion ghes < 3.3 %}
@@ -67,7 +67,7 @@ Before defining a custom pattern, you must ensure that {% data variables.product
 {% data reusables.repositories.navigate-to-code-security-and-analysis %}
 {% data reusables.repositories.navigate-to-ghas-settings %}
 {% data reusables.advanced-security.secret-scanning-new-custom-pattern %}
-{% data reusables.advanced-security.secret-scanning-add-custom-pattern-details %}{% ifversion fpt or ghec or ghes > 3.4 or ghae-issue-5499 %}
+{% data reusables.advanced-security.secret-scanning-add-custom-pattern-details %}{% ifversion secret-scanning-custom-enterprise-35 %}
 1. When you're ready to test your new custom pattern, to identify matches in the repository without creating alerts, click **Save and dry run**.
 {% data reusables.advanced-security.secret-scanning-dry-run-results %}
 {% endif %}
@@ -122,7 +122,7 @@ Before defining a custom pattern, you must ensure that you enable {% data variab
 {% data reusables.repositories.navigate-to-ghas-settings %}
 {% data reusables.advanced-security.secret-scanning-new-custom-pattern %}
 {% data reusables.advanced-security.secret-scanning-add-custom-pattern-details %}
-{%- ifversion secret-scanning-org-dry-runs %}
+{%- ifversion secret-scanning-custom-enterprise-35 %}
 1. When you're ready to test your new custom pattern, to identify matches in select repositories without creating alerts, click **Save and dry run**.
 {% data reusables.advanced-security.secret-scanning-dry-run-select-repos %}
 {% data reusables.advanced-security.secret-scanning-dry-run-results %}
@@ -141,7 +141,7 @@ Before defining a custom pattern, you must ensure that you enable secret scannin
 
 {% note %}
 
-{% ifversion secret-scanning-enterprise-dry-runs %}
+{% ifversion secret-scanning-custom-enterprise-36 %}
 **Notes:**
 - At the enterprise level, only the creator of a custom pattern can edit the pattern, and use it in a dry run. 
 - Enterprise owners can only make use of dry runs on repositories that they have access to, and enterprise owners do not necessarily have access to all the organizations or repositories within the enterprise.
@@ -158,8 +158,8 @@ Before defining a custom pattern, you must ensure that you enable secret scannin
 {% data reusables.enterprise-accounts.advanced-security-security-features %}
 1. Under "Secret scanning custom patterns", click {% ifversion ghes = 3.2 %}**New custom pattern**{% else %}**New pattern**{% endif %}.
 {% data reusables.advanced-security.secret-scanning-add-custom-pattern-details %}
-{%- ifversion secret-scanning-enterprise-dry-runs %}
-1. When you're ready to test your new custom pattern, to identify matches in the repository without creating alerts, click **Save and dry run**.
+{%- ifversion secret-scanning-custom-enterprise-36 %}
+1. When you're ready to test your new custom pattern, to identify matches in the enterprise without creating alerts, click **Save and dry run**.
 {% data reusables.advanced-security.secret-scanning-dry-run-select-repos %}
 {% data reusables.advanced-security.secret-scanning-dry-run-results %}
 {%- endif %}
@@ -175,7 +175,10 @@ When you save a change to a custom pattern, this closes all the {% data variable
    * For a repository or organization, display the "Security & analysis" settings for the repository or organization where the custom pattern was created. For more information, see "[Defining a custom pattern for a repository](#defining-a-custom-pattern-for-a-repository)" or "[Defining a custom pattern for an organization](#defining-a-custom-pattern-for-an-organization)" above.
    * For an enterprise, under "Policies" display the "Advanced Security" area, and then click **Security features**. For more information, see "[Defining a custom pattern for an enterprise account](#defining-a-custom-pattern-for-an-enterprise-account)" above.
 2. Under "{% data variables.product.prodname_secret_scanning_caps %}", to the right of the custom pattern you want to edit, click {% octicon "pencil" aria-label="The edit icon" %}.
-3. When you have reviewed and tested your changes, click **Save changes**.
+{%- ifversion secret-scanning-custom-enterprise-36 %}
+3. When you're ready to test your edited custom pattern, to identify matches without creating alerts, click **Save and dry run**.
+{%- endif %}
+4. When you have reviewed and tested your changes, click **Save changes**.
 {% endif %}
 
 ## Removing a custom pattern

data/features/secret-scanning-custom-enterprise-35.yml

@@ -0,0 +1,7 @@
+# Issues: changes to custom patterns for secret scanning
+#   #6367: updates for the "organization level dry runs (Public Beta)"
+#   #5499: updates for the "repository level dry runs (Public Beta)"
+versions:
+  ghec: '*'
+  ghes: '>3.4'
+  ghae: 'issue-6367'

data/features/secret-scanning-custom-enterprise-36.yml

@@ -0,0 +1,7 @@
+# Issues: changes to custom patterns for secret scanning
+#    #6904: updates for "enterprise account level dry runs (Public Beta)"
+#    #7297: updates for dry runs on editing patterns (Public Beta)
+versions:
+  ghec: '*'
+  ghes: '>3.5'
+  ghae: 'issue-6904'