Merge pull request github#16668 from github/repo-sync

repo sync

Author: Octomerger

.github/workflows/sync-search-indices.yml

@@ -77,6 +77,10 @@ jobs:
         env:
           VERSION: ${{ github.event.inputs.version }}
           LANGUAGE: ${{ github.event.inputs.language }}
+          # We don't want or need the changelog entries in this context.
+          # Pages that display the content from these isn't included
+          # in search index bodies anyway.
+          CHANGELOG_DISABLED: true
           # If a reusable, or anything in the `data/*` directory is deleted
           # you might get a
           #

lib/changelog.js

@@ -5,6 +5,8 @@ import path from 'path'
 import Parser from 'rss-parser'
 
 const CHANGELOG_CACHE_FILE_PATH = process.env.CHANGELOG_CACHE_FILE_PATH
+// This is useful to set when doing things like sync search.
+const CHANGELOG_DISABLED = Boolean(JSON.parse(process.env.CHANGELOG_DISABLED || 'false'))
 
 async function getRssFeed(url) {
   const parser = new Parser({ timeout: 5000 })
@@ -22,6 +24,12 @@ async function getRssFeed(url) {
 }
 
 export async function getChangelogItems(prefix, feedUrl, ignoreCache = false) {
+  if (CHANGELOG_DISABLED) {
+    if (process.env.NODE_ENV === 'development') {
+      console.warn(`Downloading changelog (${feedUrl}) items is disabled.`)
+    }
+    return
+  }
   if (!ignoreCache) {
     const fromCache = getChangelogItemsFromCache(prefix, feedUrl)
     if (fromCache) return fromCache