Merge branch 'main' into patch-2

Author: Martin Lopes

.devcontainer/devcontainer.json

@@ -15,6 +15,11 @@
 		"cSpell.language": ",en"
 	},
 
+	// Install features. Type 'feature' in the VS Code command palette for a full list.
+	"features": {
+		"git-lfs": "latest"
+	 },
+
 	// Visual Studio Code extensions which help authoring for docs.github.com.
 	"extensions": [
 		"dbaeumer.vscode-eslint",

.github/actions-scripts/get-preview-app-info.sh

@@ -13,7 +13,6 @@
 [[ -z $APP_NAME_SEED ]] && { echo "Missing APP_NAME_SEED. Exiting."; exit 1; }
 
 PREVIEW_ENV_LOCATION="eastus"
-echo "PREVIEW_ENV_LOCATION=${PREVIEW_ENV_LOCATION}" >> $GITHUB_ENV
 
 REPO_NAME="${GITHUB_REPOSITORY#*\/}"
 echo "REPO_NAME=${REPO_NAME}" >> $GITHUB_ENV
@@ -22,15 +21,14 @@ DEPLOYMENT_NAME="${REPO_NAME}-pr-${PR_NUMBER}"
 echo "DEPLOYMENT_NAME=${DEPLOYMENT_NAME}" >> $GITHUB_ENV
 
 APP_NAME_BASE="${REPO_NAME}-preview-${PR_NUMBER}"
-echo "APP_NAME_BASE=${APP_NAME_BASE}" >> $GITHUB_ENV
 
 # pseudo random string so guessing a preview env URL is more difficult
 APP_SHA=$(echo -n "${APP_NAME_SEED}-${APP_NAME_BASE}" | sha1sum | cut -c1-6)
 
 APP_NAME="${APP_NAME_BASE}-${APP_SHA}"
 echo "APP_NAME=${APP_NAME}" >> $GITHUB_ENV
 
-APP_URL="https://${APP_NAME}.${PREVIEW_ENV_LOCATION}.azurecontainer.io"
+APP_URL="https://${REPO_NAME}-${PR_NUMBER}-${APP_SHA}.preview.ghdocs.com"
 echo "APP_URL=${APP_URL}" >> $GITHUB_ENV
 
 IMAGE_REPO="${GITHUB_REPOSITORY}/pr-${PR_NUMBER}"

.github/workflows/azure-preview-env-deploy.yml

@@ -203,13 +203,10 @@ jobs:
           template: ./azure-preview-env-template.json
           deploymentName: ${{ env.DEPLOYMENT_NAME }}
           parameters: appName="${{ env.APP_NAME }}"
-            location="${{ env.PREVIEW_ENV_LOCATION }}"
             containerImage="${{ env.DOCKER_IMAGE }}"
             dockerRegistryUrl="${{ secrets.NONPROD_REGISTRY_SERVER }}"
             dockerRegistryUsername="${{ secrets.NONPROD_REGISTRY_USERNAME }}"
             dockerRegistryPassword="${{ secrets.NONPROD_REGISTRY_PASSWORD }}"
-            storageAccountName="${{ secrets.AZURE_STORAGE_ACCOUNT_NAME }}"
-            storageAccountKey="${{ secrets.AZURE_STORAGE_ACCOUNT_KEY }}"
           # this shows warnings in the github actions console, because the flag is passed through a validation run,
           # but it *is* functional during the actual execution
           additionalArguments: --no-wait

.github/workflows/test.yml

@@ -31,15 +31,14 @@ jobs:
       fail-fast: false
       matrix:
         # The same array lives in test-windows.yml, so make any updates there too.
-        test-group:
-          [
+        test-group: [
             content,
             graphql,
             meta,
             rendering,
             routing,
             unit,
-            linting,
+            # linting,
             translations,
           ]
     steps:
@@ -102,20 +101,20 @@ jobs:
       - name: Checkout LFS objects
         run: git lfs checkout
 
-      - name: Gather files changed
-        uses: trilom/file-changes-action@a6ca26c14274c33b15e6499323aac178af06ad4b
-        id: get_diff_files
-        with:
-          # So that `steps.get_diff_files.outputs.files` becomes
-          # a string like `foo.js path/bar.md`
-          output: ' '
+      # - name: Gather files changed
+      #   uses: trilom/file-changes-action@a6ca26c14274c33b15e6499323aac178af06ad4b
+      #   id: get_diff_files
+      #   with:
+      #     # So that `steps.get_diff_files.outputs.files` becomes
+      #     # a string like `foo.js path/bar.md`
+      #     output: ' '
 
-      - name: Insight into changed files
-        run: |
+      # - name: Insight into changed files
+      #   run: |
 
-          # Must to do this because the list of files can be HUGE. Especially
-          # in a repo-sync when there are lots of translation files involved.
-          echo "${{ steps.get_diff_files.outputs.files }}" > get_diff_files.txt
+      #     # Must to do this because the list of files can be HUGE. Especially
+      #     # in a repo-sync when there are lots of translation files involved.
+      #     echo "${{ steps.get_diff_files.outputs.files }}" > get_diff_files.txt
 
       - name: Setup node
         uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561
@@ -137,6 +136,6 @@ jobs:
 
       - name: Run tests
         env:
-          DIFF_FILE: get_diff_files.txt
+          # DIFF_FILE: get_diff_files.txt
           CHANGELOG_CACHE_FILE_PATH: tests/fixtures/changelog-feed.json
         run: npm test -- tests/${{ matrix.test-group }}/

LICENSE-CODE

@@ -1,6 +1,6 @@
 MIT License
 
-Copyright (c) 2020 GitHub
+Copyright 2022 GitHub
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

assets/images/enterprise/management-console/pages-override-header-section.png

@@ -11,9 +11,6 @@
         "description": "A unique name for the app"
       }
     },
-    "location": {
-      "type": "String"
-    },
     "containerImage": {
       "type": "string",
       "defaultValue": null,
@@ -32,12 +29,6 @@
     },
     "dockerRegistryPassword": {
       "type": "SecureString"
-    },
-    "storageAccountName": {
-      "type": "String"
-    },
-    "storageAccountKey": {
-      "type": "SecureString"
     }
   },
   "resources": [
@@ -83,53 +74,6 @@
                 }
               }
             }
-          },
-          {
-            "name": "caddy-ssl-server",
-            "properties": {
-              "image": "caddy:2.4.6",
-              "command": [
-                "caddy",
-                "reverse-proxy",
-                "--from",
-                "[concat(parameters('appName'), '.', parameters('location'), '.azurecontainer.io')]",
-                "--to",
-                "localhost:4000"
-              ],
-              "ports": [
-                {
-                  "protocol": "TCP",
-                  "port": 443
-                },
-                {
-                  "protocol": "TCP",
-                  "port": 80
-                }
-              ],
-              "environmentVariables": [],
-              "resources": {
-                "requests": {
-                  "memoryInGB": 1,
-                  "cpu": 1
-                }
-              },
-              "volumeMounts": [
-                {
-                  "name": "caddy-data",
-                  "mountPath": "/data"
-                }
-              ]
-            }
-          }
-        ],
-        "volumes": [
-          {
-            "name": "caddy-data",
-            "azureFile": {
-                "shareName": "caddy",
-                "storageAccountName": "[parameters('storageAccountName')]",
-                "storageAccountKey": "[parameters('storageAccountKey')]"
-            }
           }
         ],
         "imageRegistryCredentials": [
@@ -142,17 +86,9 @@
         "restartPolicy": "Always",
         "ipAddress": {
           "ports": [
-            {
-              "protocol": "TCP",
-              "port": 443
-            },
             {
               "protocol": "TCP",
               "port": 4000
-            },
-            {
-              "protocol": "TCP",
-              "port": 80
             }
           ],
           "type": "Public",