Adding global flag to regex to strip all script tags from preparation code output (#422)

Chessax · mathiasbynens · commit e127178cae81 · 2017-09-14T07:41:02.000+02:00
diff --git a/server/web/test/index.js b/server/web/test/index.js
@@ -23,7 +23,7 @@ exports.register = function (server, options, next) {
         var stripped = false;
 
         if (hasPrep) {
-          const reScripts = new RegExp(regex.script, 'i');
+          const reScripts = new RegExp(regex.script, 'gi');
           stripped = page.initHTML.replace(reScripts, '');
 
           var swappedScripts = [];
@@ -42,7 +42,7 @@ exports.register = function (server, options, next) {
               }
             ),
             true
-          ).value.replace(/@jsPerfTagToken/, () => swappedScripts.pop());
+          ).value.replace(/@jsPerfTagToken/g, () => swappedScripts.pop());
         }
 
         // update hits once per page per session

Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@ exports.register = function (server, options, next) {`
`23`	`23`	`var stripped = false;`
`24`	`24`
`25`	`25`	`if (hasPrep) {`
`26`		`- const reScripts = new RegExp(regex.script, 'i');`
	`26`	`+ const reScripts = new RegExp(regex.script, 'gi');`
`27`	`27`	`stripped = page.initHTML.replace(reScripts, '');`
`28`	`28`
`29`	`29`	`var swappedScripts = [];`
`@@ -42,7 +42,7 @@ exports.register = function (server, options, next) {`
`42`	`42`	`}`
`43`	`43`	`),`
`44`	`44`	`true`
`45`		`- ).value.replace(/@jsPerfTagToken/, () => swappedScripts.pop());`
	`45`	`+ ).value.replace(/@jsPerfTagToken/g, () => swappedScripts.pop());`
`46`	`46`	`}`
`47`	`47`
`48`	`48`	`// update hits once per page per session`