Skip to content

Commit 01d35b3

Browse files
committed
Declare IBActions in the relevant headers to silence warnings
1 parent 48ed09b commit 01d35b3

File tree

4 files changed

+61
-33
lines changed

4 files changed

+61
-33
lines changed

Classes/Controllers/PBGitHistoryController.h

Lines changed: 17 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -39,30 +39,34 @@ NS_ASSUME_NONNULL_BEGIN
3939
@property (readonly) BOOL singleCommitSelected;
4040
@property (readonly) BOOL singleNonHeadCommitSelected;
4141

42-
- (IBAction) setDetailedView:(id)sender;
43-
- (IBAction) setTreeView:(id)sender;
44-
- (IBAction) setBranchFilter:(id)sender;
45-
42+
- (BOOL)hasNonlinearPath;
43+
- (NSMenu *)tableColumnMenu;
4644
- (void)selectCommit:(GTOID *)commit;
47-
- (IBAction) refresh:(id)sender;
48-
- (IBAction) toggleQLPreviewPanel:(id)sender;
49-
- (IBAction) openSelectedFile:(id)sender;
50-
- (void) updateQuicklookForce: (BOOL) force;
45+
- (void)updateQuicklookForce: (BOOL) force;
46+
47+
- (void)setHistorySearch:(NSString *)searchString mode:(PBHistorySearchMode)mode;
5148

5249
// Context menu methods
5350
- (NSMenu *)contextMenuForTreeView;
5451
- (NSArray *)menuItemsForPaths:(NSArray *)paths;
5552
- (void)showCommitsFromTree:(id)sender;
5653

54+
- (IBAction)setDetailedView:(id)sender;
55+
- (IBAction)setTreeView:(id)sender;
56+
- (IBAction)setBranchFilter:(id)sender;
57+
58+
- (IBAction)refresh:(id)sender;
59+
- (IBAction)toggleQLPreviewPanel:(id)sender;
60+
- (IBAction)openSelectedFile:(id)sender;
61+
5762
// Find/Search methods
58-
- (void)setHistorySearch:(NSString *)searchString mode:(PBHistorySearchMode)mode;
5963
- (IBAction)selectNext:(id)sender;
6064
- (IBAction)selectPrevious:(id)sender;
6165

62-
63-
- (BOOL) hasNonlinearPath;
64-
65-
- (NSMenu *)tableColumnMenu;
66+
- (IBAction)copy:(id)sender;
67+
- (IBAction)copySHA:(id)sender;
68+
- (IBAction)copyShortName:(id)sender;
69+
- (IBAction)copyPatch:(id)sender;
6670

6771
@end
6872

Classes/Controllers/PBGitWindowController.h

Lines changed: 40 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -41,25 +41,46 @@ NS_ASSUME_NONNULL_BEGIN
4141
- (void)openURLs:(NSArray <NSURL *> *)fileURLs;
4242
- (void)revealURLsInFinder:(NSArray <NSURL *> *)fileURLs;
4343

44-
- (IBAction) showCommitView:(id)sender;
45-
- (IBAction) showHistoryView:(id)sender;
46-
- (IBAction) revealInFinder:(id)sender;
47-
- (IBAction) openInTerminal:(id)sender;
48-
- (IBAction) refresh:(id)sender;
49-
50-
- (IBAction) showAddRemoteSheet:(id)sender;
51-
52-
- (IBAction) fetchRemote:(id)sender;
53-
- (IBAction) fetchAllRemotes:(id)sender;
54-
55-
- (IBAction) pullRemote:(id)sender;
56-
- (IBAction) pullRebaseRemote:(id)sender;
57-
- (IBAction) pullDefaultRemote:(id)sender;
58-
- (IBAction) pullRebaseDefaultRemote:(id)sender;
59-
60-
- (IBAction) stashSave:(id) sender;
61-
- (IBAction) stashSaveWithKeepIndex:(id) sender;
62-
- (IBAction) stashPop:(id) sender;
44+
- (IBAction)showCommitView:(id)sender;
45+
- (IBAction)showHistoryView:(id)sender;
46+
- (IBAction)openFiles:(id)sender;
47+
- (IBAction)revealInFinder:(id)sender;
48+
- (IBAction)openInTerminal:(id)sender;
49+
- (IBAction)refresh:(id)sender;
50+
51+
- (IBAction)checkout:(id)sender;
52+
- (IBAction)createBranch:(id)sender;
53+
- (IBAction)createTag:(id)sender;
54+
- (IBAction)merge:(id)sender;
55+
- (IBAction)deleteRef:(id)sender;
56+
- (IBAction)rebase:(id)sender;
57+
- (IBAction)rebaseHeadBranch:(id)sender;
58+
- (IBAction)cherryPick:(id)sender;
59+
- (IBAction)resetSoft:(id)sender;
60+
61+
- (IBAction)showAddRemoteSheet:(id)sender GITX_DEPRECATED;
62+
- (IBAction)addRemote:(id)sender;
63+
- (IBAction)fetchRemote:(id)sender;
64+
- (IBAction)fetchAllRemotes:(id)sender;
65+
66+
- (IBAction)pullRemote:(id)sender;
67+
- (IBAction)pullRebaseRemote:(id)sender;
68+
- (IBAction)pullDefaultRemote:(id)sender;
69+
- (IBAction)pullRebaseDefaultRemote:(id)sender;
70+
71+
- (IBAction)pushUpdatesToRemote:(id)sender;
72+
- (IBAction)pushDefaultRemoteForRef:(id)sender;
73+
- (IBAction)pushToRemote:(id)sender;
74+
75+
- (IBAction)stashSave:(id) sender;
76+
- (IBAction)stashSaveWithKeepIndex:(id) sender;
77+
- (IBAction)stashPop:(id) sender;
78+
- (IBAction)stashApply:(id)sender;
79+
- (IBAction)stashDrop:(id)sender;
80+
81+
- (IBAction)diffWithHEAD:(id)sender;
82+
- (IBAction)stashViewDiff:(id)sender;
83+
- (IBAction)showTagInfoSheet:(id)sender;
6384

6485
- (void)setHistorySearch:(NSString *)searchString mode:(PBHistorySearchMode)mode;
6586

Classes/Controllers/PBGitWindowController.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -770,7 +770,7 @@ - (IBAction) refresh:(id)sender
770770
[contentController refresh:self];
771771
}
772772

773-
- (void) createBranch:(id)sender
773+
- (IBAction) createBranch:(id)sender
774774
{
775775
PBGitRef *currentRef = [self.repository.currentBranch ref];
776776

Classes/Views/PBRefMenuItem.m

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,9 @@
1010
#import "PBGitRepository.h"
1111
#import "PBGitRevSpecifier.h"
1212

13+
#import "PBGitWindowController.h"
14+
#import "PBGitHistoryController.h"
15+
1316
/*
1417
* TODO: This is kept for simplicity reasons. A "more correct" way of handling
1518
* menus would be to have them in NIBs, and handle them using NSMenuValidation.

0 commit comments

Comments
 (0)