Implicit self-retains in blocks warnings

Author: tiennou

Classes/Controllers/PBGitWindowController.m

@@ -191,7 +191,7 @@ - (void)showCommitHookFailedSheet:(NSString *)messageText infoText:(NSString *)i
 	 completionHandler:^(id  _Nonnull sheet, NSModalResponse returnCode) {
 		 if (returnCode != NSModalResponseOK) return;
 
-		 [_commitViewController forceCommit:self];
+		 [self.commitViewController forceCommit:self];
 	 }];
 }
 

Classes/Controllers/PBHistorySearchController.m

@@ -439,7 +439,7 @@ - (void)startBackgroundSearch
 			NSError *error = [NSError pb_errorWithDescription:desc
 												failureReason:reason
 											  underlyingError:taskError];
-			[historyController.windowController showErrorSheet:error];
+			[self->historyController.windowController showErrorSheet:error];
 			return;
 		}
 		[self parseBackgroundSearchResults:readData];

Classes/Controllers/PBWebHistoryController.m

@@ -140,7 +140,7 @@ - (void) changeContentToCommit:(PBGitCommit *)commit
 
 	dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_HIGH, 0), ^{
 		NSDictionary *summary = loadCommitSummary(repo, queueCommit, ^BOOL {
-			return gen != atomic_load(&_commitSummaryGeneration);
+			return gen != atomic_load(&self->_commitSummaryGeneration);
 		});
 		if (!summary) return;
 		NSError *err = nil;

Classes/Views/PBCloneRepositoryPanel.m

@@ -148,7 +148,7 @@ - (IBAction) clone:(id)sender
 
 			[self close];
 
-			NSString *containingPath = [path stringByDeletingLastPathComponent];
+			NSString *containingPath = [self->path stringByDeletingLastPathComponent];
 			[PBGitDefaults setRecentCloneDestination:containingPath];
 			[self.destinationPath setStringValue:containingPath];
 			[self.repositoryURL setStringValue:@""];
@@ -162,7 +162,7 @@ - (IBAction) browseRepository:(id)sender
     [browseRepositoryPanel beginSheetModalForWindow:[self window]
                                   completionHandler:^(NSInteger result) {
                                       if (result == NSModalResponseOK) {
-                                          NSURL *url = [[browseRepositoryPanel URLs] lastObject];
+                                          NSURL *url = [[self->browseRepositoryPanel URLs] lastObject];
                                           [self.repositoryURL setStringValue:[url path]];
                                       }
                                   }];
@@ -182,7 +182,7 @@ - (IBAction) browseDestination:(id)sender
     [browseDestinationPanel beginSheetModalForWindow:[self window]
                                    completionHandler:^(NSInteger result) {
                                        if (result == NSModalResponseOK) {
-                                           NSURL *url = [[browseDestinationPanel URLs] lastObject];
+                                           NSURL *url = [[self->browseDestinationPanel URLs] lastObject];
                                            [self.destinationPath setStringValue:[url path]];
                                        }
                                    }];

Classes/git/PBGitIndex.m

@@ -159,7 +159,7 @@ - (void)refresh
 					 [self postIndexRefreshSuccess:YES message:@"update-index success"];
 				 }
 
-				 dispatch_group_leave(_indexRefreshGroup);
+				 dispatch_group_leave(self->_indexRefreshGroup);
 			 }];
 
 
@@ -217,7 +217,7 @@ - (void)refresh
 		 }
 
 		 [self postIndexRefreshSuccess:YES message:@"ls-files success"];
-		 dispatch_group_leave(_indexRefreshGroup);
+		 dispatch_group_leave(self->_indexRefreshGroup);
 	 }];
 
 	// Staged files
@@ -236,7 +236,7 @@ - (void)refresh
 
 		 [self postIndexRefreshSuccess:YES message:@"diff-index success"];
 
-		 dispatch_group_leave(_indexRefreshGroup);
+		 dispatch_group_leave(self->_indexRefreshGroup);
 	 }];
 
 
@@ -255,7 +255,7 @@ - (void)refresh
 		 }
 		 [self postIndexRefreshSuccess:YES message:@"diff-files success"];
 
-		 dispatch_group_leave(_indexRefreshGroup);
+		 dispatch_group_leave(self->_indexRefreshGroup);
 	 }];
 }