Fix double-clicking the stage/unstage tableview

tiennou · tiennou · commit a197b1c8b2ac · 2018-09-28T22:24:05.000+02:00
diff --git a/Classes/Controllers/PBGitCommitController.m b/Classes/Controllers/PBGitCommitController.m
@@ -643,14 +643,14 @@ - (void)tableView:(NSTableView*)tableView willDisplayCell:(id)cell forTableColum
 
 - (void) didDoubleClickOnTable:(NSTableView *) tableView
 {
-	NSArrayController *controller = [tableView tag] == 0 ? unstagedFilesController : stagedFilesController;
+	NSArrayController *controller = (tableView == unstagedTable ? unstagedFilesController : stagedFilesController);
 
 	NSIndexSet *selectionIndexes = [tableView selectedRowIndexes];
 	NSArray *files = [[controller arrangedObjects] objectsAtIndexes:selectionIndexes];
-	if ([tableView tag] == 0) {
+
+	if (tableView == unstagedTable) {
 		[self.index stageFiles:files];
-	}
-	else {
+	} else {
 		[self.index unstageFiles:files];
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -643,14 +643,14 @@ - (void)tableView:(NSTableView*)tableView willDisplayCell:(id)cell forTableColum`
`643`	`643`
`644`	`644`	`- (void) didDoubleClickOnTable:(NSTableView *) tableView`
`645`	`645`	`{`
`646`		`- NSArrayController *controller = [tableView tag] == 0 ? unstagedFilesController : stagedFilesController;`
	`646`	`+ NSArrayController *controller = (tableView == unstagedTable ? unstagedFilesController : stagedFilesController);`
`647`	`647`
`648`	`648`	`NSIndexSet *selectionIndexes = [tableView selectedRowIndexes];`
`649`	`649`	`NSArray *files = [[controller arrangedObjects] objectsAtIndexes:selectionIndexes];`
`650`		`- if ([tableView tag] == 0) {`
	`650`	`+`
	`651`	`+ if (tableView == unstagedTable) {`
`651`	`652`	`[self.index stageFiles:files];`
`652`		`- }`
`653`		`- else {`
	`653`	`+ } else {`
`654`	`654`	`[self.index unstageFiles:files];`
`655`	`655`	`}`
`656`	`656`	`}`