Missing selectors

Author: tiennou

Classes/Controllers/PBWebController.m

@@ -68,6 +68,10 @@ - (void)closeView
 	[[NSNotificationCenter defaultCenter] removeObserver:self];
 }
 
+- (void)didLoad
+{
+}
+
 # pragma mark Delegate methods
 
 - (void)webView:(WebView *)sender didClearWindowObject:(WebScriptObject *)windowObject forFrame:(WebFrame *)frame

Classes/git/PBGitHistoryGrapher.h

@@ -15,17 +15,22 @@
 
 @class PBGitGrapher;
 
+@protocol PBGitHistoryGrapherDelegate <NSObject>
+- (void)updateCommitsFromGrapher:(NSDictionary *)commitData;
+- (void)finishedGraphing;
+@end
+
 
 @interface PBGitHistoryGrapher : NSObject {
-	__weak id delegate;
+	__weak id <PBGitHistoryGrapherDelegate> delegate;
 	NSOperationQueue *currentQueue;
 
 	NSMutableSet *searchOIDs;
 	PBGitGrapher *grapher;
 	BOOL viewAllBranches;
 }
 
-- (id) initWithBaseCommits:(NSSet *)commits viewAllBranches:(BOOL)viewAll queue:(NSOperationQueue *)queue delegate:(id)theDelegate;
+- (instancetype) initWithBaseCommits:(NSSet *)commits viewAllBranches:(BOOL)viewAll queue:(NSOperationQueue *)queue delegate:(id <PBGitHistoryGrapherDelegate>)theDelegate;
 - (void) graphCommits:(NSArray *)revList;
 
 @end

Classes/git/PBGitHistoryGrapher.m

@@ -13,9 +13,10 @@
 @implementation PBGitHistoryGrapher
 
 
-- (id) initWithBaseCommits:(NSSet *)commits viewAllBranches:(BOOL)viewAll queue:(NSOperationQueue *)queue delegate:(id)theDelegate
+- (instancetype) initWithBaseCommits:(NSSet *)commits viewAllBranches:(BOOL)viewAll queue:(NSOperationQueue *)queue delegate:(id <PBGitHistoryGrapherDelegate>)theDelegate
 {
     self = [super init];
+	if (!self) return nil;
 
 	delegate = theDelegate;
 	currentQueue = queue;
@@ -29,9 +30,9 @@ - (id) initWithBaseCommits:(NSSet *)commits viewAllBranches:(BOOL)viewAll queue:
 
 - (void)sendCommits:(NSArray *)commits
 {
-	NSDictionary *commitData = [NSDictionary dictionaryWithObjectsAndKeys:currentQueue, kCurrentQueueKey, commits, kNewCommitsKey, nil];
-	id strongDelegate = delegate;
-	[strongDelegate performSelectorOnMainThread:@selector(updateCommitsFromGrapher:) withObject:commitData waitUntilDone:NO];
+	dispatch_async(dispatch_get_main_queue(), ^{
+		[self->delegate updateCommitsFromGrapher:@{ kCurrentQueueKey: self->currentQueue, kNewCommitsKey: commits }];
+	});
 }
 
 

Classes/git/PBGitHistoryList.m

@@ -14,7 +14,7 @@
 #import "PBGitRef.h"
 #import "PBGitRevSpecifier.h"
 
-@interface PBGitHistoryList ()
+@interface PBGitHistoryList () <PBGitHistoryGrapherDelegate>
 
 - (void) resetGraphing;