Skip to content

Commit bb8a516

Browse files
committed
Whack all the memory leaks
1 parent 16d4135 commit bb8a516

File tree

4 files changed

+10
-2
lines changed

4 files changed

+10
-2
lines changed

Classes/Controllers/PBGitCommitController.m

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -135,6 +135,7 @@ - (void)closeView
135135
{
136136
[[NSNotificationCenter defaultCenter] removeObserver:self];
137137
[webController closeView];
138+
[super closeView];
138139
}
139140

140141
- (NSResponder *)firstResponder;

Classes/Controllers/PBGitSidebarController.m

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -125,6 +125,11 @@ - (void)awakeFromNib
125125
[[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(expandCollapseItem:) name:NSOutlineViewItemWillCollapseNotification object:sourceView];
126126
}
127127

128+
- (void)closeView
129+
{
130+
[super closeView];
131+
}
132+
128133
- (void)dealloc
129134
{
130135
[[NSNotificationCenter defaultCenter] removeObserver:self name:NSOutlineViewItemWillExpandNotification object:sourceView];

Classes/Controllers/PBViewController.m

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,9 @@ - (void)closeView
3535
{
3636
[self unbind:@"repository"];
3737
if (_hasViewLoaded)
38-
[[self view] removeFromSuperview]; // remove the current view
38+
[[self view] removeFromSuperview]; // remove the current view
39+
repository = nil;
40+
superController = nil;
3941
}
4042

4143
- (void)awakeFromNib

Classes/Views/PBSourceViewItem.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ NS_ASSUME_NONNULL_BEGIN
4040
@property (getter=isUncollapsible) BOOL uncollapsible;
4141
@property (getter=isExpanded) BOOL expanded;
4242
@property PBGitRevSpecifier *revSpecifier;
43-
@property PBSourceViewItem *parent;
43+
@property (weak) PBSourceViewItem *parent;
4444
@property (readonly) NSString *iconName;
4545
@property (nullable, readonly) NSImage *icon;
4646

0 commit comments

Comments
 (0)