Extract date formatter creation

Author: tiennou

Classes/GitXRelativeDateFormatter.h

@@ -9,8 +9,5 @@
 #import <Cocoa/Cocoa.h>
 
 
-@interface GitXRelativeDateFormatter : NSFormatter {
-
-}
-
+@interface GitXRelativeDateFormatter : NSFormatter
 @end

Classes/GitXRelativeDateFormatter.m

@@ -14,7 +14,6 @@
 
 #define WEEK 7
 
-
 @implementation GitXRelativeDateFormatter
 
 - (NSString *)stringForObjectValue:(id)date
@@ -41,11 +40,16 @@ - (NSString *)stringForObjectValue:(id)date
 	if (secondsAgo < (2 * HOUR))
 		return @"1 hour ago";
 
+	static NSDateFormatter *midnightFormatter = nil;
+	static dispatch_once_t onceToken;
+	dispatch_once(&onceToken, ^{
+		midnightFormatter = [[NSDateFormatter alloc] init];
+		midnightFormatter.dateFormat = @"yyyy-MM-dd";
+	});
+
 	// figure out # of days ago based on calender days (so yesterday is the day before today not 24 hours ago)
-	NSDateFormatter *midnightFormmatter = [[NSDateFormatter alloc] init];
-	[midnightFormmatter setDateFormat:@"yyyy-MM-dd"];
-	NSDate *midnightOnTargetDate = [midnightFormmatter dateFromString:[midnightFormmatter stringFromDate:date]];
-	NSDate *midnightToday = [midnightFormmatter dateFromString:[midnightFormmatter stringFromDate:now]];
+	NSDate *midnightOnTargetDate = [midnightFormatter dateFromString:[midnightFormatter stringFromDate:date]];
+	NSDate *midnightToday = [midnightFormatter dateFromString:[midnightFormatter stringFromDate:now]];
 
 	// use NSCalendar so it will handle things like leap years correctly
 	NSDateComponents *components = [[NSCalendar currentCalendar] components:(NSCalendarUnitYear | NSCalendarUnitMonth | NSCalendarUnitDay)