Skip to content

Commit 1f53582

Browse files
committed
add default mimeType if none is specified
1 parent 81612ff commit 1f53582

File tree

4 files changed

+16
-3
lines changed

4 files changed

+16
-3
lines changed

.changeset/sixty-ears-tan.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"jspsych": patch
3+
---
4+
5+
add a default `mimeType` of `"video/webm" to `initializeCameraRecorder()`

docs/reference/jspsych-pluginAPI.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -507,8 +507,7 @@ None.
507507

508508
#### Description
509509

510-
Generates a `MediaRecorder` object from provided `MediaStream` and stores this for access via [`getCameraRecorder()`](#getcamerarecorder).
511-
510+
Generates a `MediaRecorder` object from provided `MediaStream` and stores this for access via [`getCameraRecorder()`](#getcamerarecorder). By default, `mimeType` is set to `"video/webm"`.
512511
#### Example
513512

514513
```javascript

examples/extension-record-video.html

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,10 @@
1313
const jsPsych = initJsPsych({
1414
extensions: [
1515
{type: jsPsychExtensionRecordVideo}
16-
]
16+
],
17+
on_finish: function() {
18+
jsPsych.data.displayData();
19+
}
1720
});
1821

1922
const initCamera = {

packages/jspsych/src/modules/plugin-api/MediaAPI.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -284,6 +284,12 @@ export class MediaAPI {
284284
private camera_recorder: MediaRecorder = null;
285285

286286
initializeCameraRecorder(stream: MediaStream, opts?: MediaRecorderOptions) {
287+
if (!opts) {
288+
opts = { mimeType: "video/webm" };
289+
} else if (!opts.mimeType) {
290+
opts.mimeType = "video/webm";
291+
}
292+
287293
this.camera_stream = stream;
288294
const recorder = new MediaRecorder(stream, opts);
289295
this.camera_recorder = recorder;

0 commit comments

Comments
 (0)