Skip to content

Commit a6ec7a2

Browse files
authored
Merge pull request #3563 from farhat60/bugfix/3562-image-button-enable_after
fix: enable_button_after parameter in plugin-image-button-response (closes #3562)
2 parents 6b15c17 + c902be3 commit a6ec7a2

File tree

3 files changed

+8
-3
lines changed

3 files changed

+8
-3
lines changed

.changeset/busy-tires-reply.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@jspsych/plugin-image-button-response": minor
3+
---
4+
5+
CSS selector that queries the button to disable it was trying to get a class. Now it looks for the correct id and disables the button.

packages/plugin-image-button-response/src/index.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ describe("image-button-response", () => {
147147
},
148148
]);
149149

150-
const btns = displayElement.querySelectorAll(".jspsych-image-button-response-button button");
150+
const btns = displayElement.querySelectorAll("#jspsych-image-button-response-btngroup button");
151151

152152
for (let i = 0; i < btns.length; i++) {
153153
expect(btns[i].getAttribute("disabled")).toBe("disabled");

packages/plugin-image-button-response/src/index.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -306,14 +306,14 @@ class ImageButtonResponsePlugin implements JsPsychPlugin<Info> {
306306
}
307307

308308
function enable_buttons() {
309-
var btns = document.querySelectorAll(".jspsych-image-button-response-button button");
309+
var btns = document.querySelectorAll("#jspsych-image-button-response-btngroup button");
310310
for (var i = 0; i < btns.length; i++) {
311311
btns[i].removeAttribute("disabled");
312312
}
313313
}
314314

315315
function disable_buttons() {
316-
var btns = document.querySelectorAll(".jspsych-image-button-response-button button");
316+
var btns = document.querySelectorAll("#jspsych-image-button-response-btngroup button");
317317
for (var i = 0; i < btns.length; i++) {
318318
btns[i].setAttribute("disabled", "disabled");
319319
}

0 commit comments

Comments
 (0)