Repetitions parameter returning extra reps of timeline defined using conditional_function

[amyxli]

Hello! I’ve been stuck on a really strange problem with using the repetitions parameter with conditional timelines -- and have tried everything I can possibly think of. Was wondering if any part of this would sound familiar to anyone?

The context: I have a trial variable (LP) that refers to 2 ‘child’ trial variables (ifTarget/ ifNontarget) in order to repeat them N times. Each child variable has a conditional_function parameter that defines whether that variable is the one that should be included for the trial trialN. I have also just attached the code below.

The problem: more repetitions are sometimes displayed than specified in repetitions. Here is the pattern – when repetitions = 32 to 62 inclusive, 1 extra trial is shown (e.g., 33 trials instead of 32 when repetitions = 32). When repetitions = 64 to 95 inclusive, 2 extra trials are shown. When repetitions = 96 to 128 inclusive, 3 extra trials are shown.

Since the pattern corresponds to the ‘boundaries’ defined in conditional_function, I suspect that whatever is in conditional_function is somehow causing problems for repetitions in the higher-level LP variable (please see below). But can’t work out for the life of me why this would be happening…

Would anyone happen to have any ideas? Thanks so much for any pointers!

// here's the code for context

// this variable represents the timeline that will be returned, if the value of trialN corresponds with that of a target trial
var ifTarget = {
  timeline: [dimQ, dimQ_postdeadline, accumulate_dimQ_index, decision_LP, feedbackPartial], // this is the sequence presented for each trial if trialN tells us it's a target trial. Each variable in this array has its own 'type', 'stimulus', 'choices' etc. parameters)
  conditional_function: function(){
      if (dimQ_condition == "withDimQ"){
        if ((trialN >= 16 && trialN < 32) | (trialN >= 48 && trialN < 64) | (trialN >= 80 && trialN < 96) | (trialN >= 112)){  /// I think this might be interacting with REPETITIONS given the pattern in the errors. 
//also if I change the part in the first bracket to trialN < 33 then set repetitions = 32, there are no extra trials shown 
          //console.log('ifTarget, trialN = ' + trialN) 
          return true
        } else {return false}
      } else {return false}
  },
}


// this variable represents the timeline that will be returned, if the value of trialN corresponds with that of a non-target trial
var ifNontarget = {
  timeline: [decision_LP, feedbackPartial], // this is the sequence presented for each trial if trialN tells us it's not a target trial
  conditional_function: function(){
      if (dimQ_condition == "withDimQ"){
        if ((trialN >= 16 && trialN < 32) | (trialN >= 48 && trialN < 64) | (trialN >= 80 && trialN < 96) | (trialN >= 112)){
            return false
        } else {
          //console.log('ifNontarget, trialN = ' + trialN)
          return true;
        }
      } else {return false}
  },
}

var LP = {
  timeline: [ifTarget, ifNontarget], // only ONE of these will be displayed since the other will be skipped
  repetitions: 32, // for example...
};
          
timeline.push(LP);

// note: if the console.log messages are included, there isn’t any trial where both console.log messages are shown (i.e., no trials that seem to be fulfilling conditions for both ifTarget and ifNontarget 

[amyxli]

Update: this has been solved with help outside of the forum!

Just in case anyone's having the same problem, it was due to trialN accumulating at the end of feedbackPartial. That meant that on trialN = 31 (the 32nd repetition), ifTarget is run and at the end trialN becomes 32. However because ifNontarget is still run within the same 32nd repetition of LP, trialN = 32 ends up returning true for the conditional in ifNontarget, which results in the extra trial.