Can't timeline.push within a function?

[letitiayhho]

Due to the nested nature of my experimental design, it seems like the best way to create trials is with an explicit for loop. For some reason however, I can successfully push the trials to my timeline when they are outside a function (see 1), but the trials will push but the timeline won't move on to the next item if its within a function (see 2). Any ideas why?

1. This works

      for (let trial = 1; trial < n + 1; trial++) { 
        console.log({ trial });
        timeline.push(make_trial(block_number, trial));
        timeline.push(pause)
      } 

2. This will not

      function make_block(block_number, trial, n) {
        for (let trial = 1; trial < n + 1; trial++) {
          console.log({ trial });
          timeline.push(make_trial(block_number, trial));
          timeline.push(pause)
        }
      }

timeline.push(make_block(block_number, trial, n))
timeline.push(pause) // this will not show up after make_block()

[nikbpetrov]

Calling the function in 2 should return a value - you do not return anything, instead you push to the timeline.

Two options:

      function make_block(block_number, trial, n) {
        temp_timeline = []
        for (let trial = 1; trial < n + 1; trial++) {
          console.log({ trial });
          temp_timeline.push(make_trial(block_number, trial));
          temp_timeline.push(pause)
        }
        // note that because this will be added to the main timeline later, this needs to be return like a timeline object, not array
        return {timeline: temp_timeline}
      }

timeline.push(make_block(block_number, trial, n))
timeline.push(pause)

or

      function make_block(block_number, trial, n) {
        for (let trial = 1; trial < n + 1; trial++) {
          console.log({ trial });
          timeline.push(make_trial(block_number, trial));
          timeline.push(pause)
        }
      }

make_block(block_number, trial, n)
timeline.push(pause)

[letitiayhho]

#1 worked for me, thanks! #2 still didn't work, it wouldn't move on to the next timeline item for some reason.