coll/hcoll: bugfix: initialize req_type field

Valentin Petrov · jladd-mlnx · commit 5eb903047cb0 · 2016-05-25T18:50:43.000+03:00
If left uninitialized then segfault is possible in MPI_Waitall in the case the field by chance equals OMPI_REQUEST_GEN. (cherry picked from commit 5ff6372)
diff --git a/ompi/mca/coll/hcoll/coll_hcoll_rte.c b/ompi/mca/coll/hcoll/coll_hcoll_rte.c
@@ -400,6 +400,7 @@ static void* get_coll_handle(void)
     ompi_req->req_status.MPI_ERROR = MPI_SUCCESS;
     ompi_req->req_state = OMPI_REQUEST_ACTIVE;
     ompi_req->req_free = request_free;
+    ompi_req->req_type = OMPI_REQUEST_COLL;
     return (void *)ompi_req;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -400,6 +400,7 @@ static void* get_coll_handle(void)`
`400`	`400`	`ompi_req->req_status.MPI_ERROR = MPI_SUCCESS;`
`401`	`401`	`ompi_req->req_state = OMPI_REQUEST_ACTIVE;`
`402`	`402`	`ompi_req->req_free = request_free;`
	`403`	`+ ompi_req->req_type = OMPI_REQUEST_COLL;`
`403`	`404`	`return (void *)ompi_req;`
`404`	`405`	`}`
`405`	`406`