coll/libnbc: fix coverity errors

Fix CID 1196812: Resource Leak

dsts array was leaked on error.

Fix CID 710565: Copy-paste error

The line in question (nbc:513) is indeed a copy-paste error.

Signed-off-by: Nathan Hjelm <[email protected]>

(cherry picked from open-mpi/ompi@30f8d0b)

Author: hjelmn

ompi/mca/coll/libnbc/nbc.c

@@ -508,7 +508,7 @@ static inline int NBC_Start_round(NBC_Handle *handle) {
         if(unpackargs.tmpinbuf) {
           buf1=(char*)handle->tmpbuf+(long)unpackargs.inbuf;
         } else {
-          buf1=unpackargs.outbuf;
+          buf1=unpackargs.inbuf;
         }
         if(unpackargs.tmpoutbuf) {
           buf2=(char*)handle->tmpbuf+(long)unpackargs.outbuf;

ompi/mca/coll/libnbc/nbc_ineighbor_alltoallw.c

@@ -85,6 +85,7 @@ int ompi_coll_libnbc_ineighbor_alltoallw(void *sbuf, int *scounts, MPI_Aint *sdi
     free (srcs);
 
     if (OPAL_UNLIKELY(OMPI_SUCCESS != res)) {
+      free (dsts);
       OBJ_RELEASE(schedule);
       return res;
     }