Skip to content

Commit 7a39b3e

Browse files
author
Francois WELLENREITER
committed
MTL portals4 : remove useless PtlMDBind PtlMDRelease calls for rendez-vous messages
1 parent 1960f2c commit 7a39b3e

File tree

2 files changed

+3
-25
lines changed

2 files changed

+3
-25
lines changed

ompi/mca/mtl/portals4/mtl_portals4_recv.c

Lines changed: 3 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -39,36 +39,18 @@ read_msg(void *start, ptl_size_t length, ptl_process_t target,
3939
ptl_match_bits_t match_bits, ptl_size_t remote_offset,
4040
ompi_mtl_portals4_recv_request_t *request)
4141
{
42-
ptl_md_t md;
4342
int ret;
4443

45-
/* FIX ME: This needs to be on the send eq... */
46-
md.start = start;
47-
md.length = length;
48-
md.options = 0;
49-
md.eq_handle = ompi_mtl_portals4.send_eq_h;
50-
md.ct_handle = PTL_CT_NONE;
51-
52-
ret = PtlMDBind(ompi_mtl_portals4.ni_h,
53-
&md,
54-
&request->md_h);
55-
if (OPAL_UNLIKELY(PTL_OK != ret)) {
56-
opal_output_verbose(1, ompi_mtl_base_framework.framework_output,
57-
"%s:%d: PtlMDBind failed: %d",
58-
__FILE__, __LINE__, ret);
59-
return OMPI_ERR_OUT_OF_RESOURCE;
60-
}
61-
6244
#if OMPI_MTL_PORTALS4_FLOW_CONTROL
6345
while (OPAL_UNLIKELY(OPAL_THREAD_ADD32(&ompi_mtl_portals4.flowctl.send_slots, -1) < 0)) {
6446
OPAL_THREAD_ADD32(&ompi_mtl_portals4.flowctl.send_slots, 1);
6547
ompi_mtl_portals4_progress();
6648
}
6749
#endif
6850

69-
ret = PtlGet(request->md_h,
70-
0,
71-
md.length,
51+
ret = PtlGet(ompi_mtl_portals4.send_md_h,
52+
(ptl_size_t) start,
53+
length,
7254
target,
7355
ompi_mtl_portals4.read_idx,
7456
match_bits,
@@ -78,7 +60,6 @@ read_msg(void *start, ptl_size_t length, ptl_process_t target,
7860
opal_output_verbose(1, ompi_mtl_base_framework.framework_output,
7961
"%s:%d: PtlGet failed: %d",
8062
__FILE__, __LINE__, ret);
81-
PtlMDRelease(request->md_h);
8263
return OMPI_ERR_OUT_OF_RESOURCE;
8364
}
8465

@@ -178,7 +159,6 @@ ompi_mtl_portals4_recv_progress(ptl_event_t *ev,
178159
opal_output_verbose(1, ompi_mtl_base_framework.framework_output,
179160
"%s:%d: PTL_EVENT_REPLY with ni_fail_type: %d",
180161
__FILE__, __LINE__, ev->ni_fail_type);
181-
PtlMDRelease(ptl_request->md_h);
182162
goto callback_error;
183163
}
184164

@@ -208,7 +188,6 @@ ompi_mtl_portals4_recv_progress(ptl_event_t *ev,
208188
__FILE__, __LINE__, ret);
209189
ptl_request->super.super.ompi_req->req_status.MPI_ERROR = ret;
210190
}
211-
PtlMDRelease(ptl_request->md_h);
212191

213192
OPAL_OUTPUT_VERBOSE((50, ompi_mtl_base_framework.framework_output,
214193
"Recv %lu (0x%lx) completed, reply",

ompi/mca/mtl/portals4/mtl_portals4_request.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,6 @@ typedef struct ompi_mtl_portals4_send_request_t ompi_mtl_portals4_send_request_t
6868
struct ompi_mtl_portals4_recv_request_t {
6969
ompi_mtl_portals4_base_request_t super;
7070
void *buffer_ptr;
71-
ptl_handle_md_t md_h;
7271
ptl_handle_me_t me_h;
7372
struct opal_convertor_t *convertor;
7473
void *delivery_ptr;

0 commit comments

Comments
 (0)