opal_progress_threads: fix double RELEASE

jsquyres · jsquyres · commit b3b12244dd10 · 2015-10-22T11:45:48.000-07:00
If a thread failed to start, the tracker would be released twice. This commit fixes CID 1316020. (cherry picked from commit open-mpi/ompi@92bc8af)
diff --git a/opal/runtime/opal_progress_threads.c b/opal/runtime/opal_progress_threads.c
@@ -132,7 +132,6 @@ static int start_progress_engine(opal_progress_tracker_t *trk)
     int rc = opal_thread_start(&trk->engine);
     if (OPAL_SUCCESS != rc) {
         OPAL_ERROR_LOG(rc);
-        OBJ_RELEASE(trk);
     }
 
     return rc;

Original file line number	Diff line number	Diff line change
`@@ -132,7 +132,6 @@ static int start_progress_engine(opal_progress_tracker_t *trk)`
`132`	`132`	`int rc = opal_thread_start(&trk->engine);`
`133`	`133`	`if (OPAL_SUCCESS != rc) {`
`134`	`134`	`OPAL_ERROR_LOG(rc);`
`135`		`- OBJ_RELEASE(trk);`
`136`	`135`	`}`
`137`	`136`
`138`	`137`	`return rc;`