Skip to content

Commit b65e940

Browse files
committed
make adjustments for the default settings of grouping parameters and the default contiguous group size option.
minor bug fix in the simple grouping strategy.
1 parent c5a7e6e commit b65e940

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

ompi/mca/io/ompio/io_ompio.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ OMPI_DECLSPEC extern int mca_io_ompio_coll_timing_info;
112112

113113
#define OMPIO_UNIFORM_DIST_THRESHOLD 0.5
114114
#define OMPIO_CONTG_THRESHOLD 1048576
115-
#define OMPIO_CONTG_FACTOR 4
115+
#define OMPIO_CONTG_FACTOR 8
116116
#define OMPIO_DEFAULT_STRIPE_SIZE 1048576
117117
#define OMPIO_PROCS_PER_GROUP_TAG 0
118118
#define OMPIO_PROCS_IN_GROUP_TAG 1

ompi/mca/io/ompio/io_ompio_component.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ int mca_io_ompio_record_offset_info = 0;
3838
int mca_io_ompio_coll_timing_info = 0;
3939
int mca_io_ompio_sharedfp_lazy_open = 1;
4040

41-
int mca_io_ompio_grouping_option=4;
41+
int mca_io_ompio_grouping_option=5;
4242

4343
/*
4444
* Private functions
@@ -202,12 +202,12 @@ static int register_component(void)
202202
MCA_BASE_VAR_SCOPE_READONLY,
203203
&mca_io_ompio_sharedfp_lazy_open);
204204

205-
mca_io_ompio_grouping_option = 4;
205+
mca_io_ompio_grouping_option = 5;
206206
(void) mca_base_component_var_register(&mca_io_ompio_component.io_version,
207207
"grouping_option",
208208
"Option for grouping of processes in the aggregator selection "
209-
"1: Data volume based grouping 2: create uniform groups 3: maximimze "
210-
"contiguity 4: hybrid optimization (default) 5: simple/no optimization "
209+
"1: Data volume based grouping 2: maximizing group size uniformity 3: maximimze "
210+
"data contiguity 4: hybrid optimization 5: simple (default) "
211211
"6: skip refinement step",
212212
MCA_BASE_VAR_TYPE_INT, NULL, 0, 0,
213213
OPAL_INFO_LVL_9,

ompi/mca/io/ompio/io_ompio_file_set_view.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -327,8 +327,8 @@ int mca_io_ompio_simple_grouping(mca_io_ompio_file_t *fh,
327327
group_size = (((int)stripe_size/(int)fh->f_cc_size) > fh->f_size ) ? fh->f_size : ((int)stripe_size/(int)fh->f_cc_size);
328328
*num_groups = fh->f_size / group_size;
329329
}
330-
else if ( fh->f_cc_size < OMPIO_CONTG_FACTOR * stripe_size) {
331-
*num_groups = fh->f_size / OMPIO_CONTG_FACTOR;
330+
else if ( fh->f_cc_size <= OMPIO_CONTG_FACTOR * stripe_size) {
331+
*num_groups = fh->f_size/OMPIO_CONTG_FACTOR > 0 ? (fh->f_size/OMPIO_CONTG_FACTOR) : 1 ;
332332
group_size = OMPIO_CONTG_FACTOR;
333333
}
334334
else {
@@ -349,7 +349,7 @@ int mca_io_ompio_simple_grouping(mca_io_ompio_file_t *fh,
349349
k++;
350350
}
351351
}
352-
352+
sleep (10);
353353
return OMPI_SUCCESS;
354354
}
355355

0 commit comments

Comments
 (0)