fix coverty warning 72107

edgargabriel · edgargabriel · commit f6b3df21d281 · 2015-08-25T09:54:16.000-05:00
diff --git a/ompi/mca/io/ompio/io_ompio.c b/ompi/mca/io/ompio/io_ompio.c
@@ -1452,20 +1452,21 @@ int ompi_io_ompio_distribute_file_view (mca_io_ompio_file_t *fh,
     }
     */
  exit:
-    for (i=0 ; i<num_aggregators ; i++) {
-        if (NULL != broken[i]) {
-            free (broken[i]);
+
+    if (NULL != broken) {
+        for (i=0 ; i<num_aggregators ; i++) {
+            if (NULL != broken[i]) {
+                free (broken[i]);
+            }
         }
+        free (broken);
     }
     if (NULL != req) {
         free (req);
     }
     if (NULL != sendreq) {
         free (sendreq);
     }
-    if (NULL != broken) {
-        free (broken);
-    }
     free (num_entries);
     free (broken_index);
     if (NULL != displs) {

Original file line number	Diff line number	Diff line change
`@@ -1452,20 +1452,21 @@ int ompi_io_ompio_distribute_file_view (mca_io_ompio_file_t *fh,`
`1452`	`1452`	`}`
`1453`	`1453`	`*/`
`1454`	`1454`	`exit:`
`1455`		`- for (i=0 ; i<num_aggregators ; i++) {`
`1456`		`- if (NULL != broken[i]) {`
`1457`		`- free (broken[i]);`
	`1455`	`+`
	`1456`	`+ if (NULL != broken) {`
	`1457`	`+ for (i=0 ; i<num_aggregators ; i++) {`
	`1458`	`+ if (NULL != broken[i]) {`
	`1459`	`+ free (broken[i]);`
	`1460`	`+ }`
`1458`	`1461`	`}`
	`1462`	`+ free (broken);`
`1459`	`1463`	`}`
`1460`	`1464`	`if (NULL != req) {`
`1461`	`1465`	`free (req);`
`1462`	`1466`	`}`
`1463`	`1467`	`if (NULL != sendreq) {`
`1464`	`1468`	`free (sendreq);`
`1465`	`1469`	`}`
`1466`		`- if (NULL != broken) {`
`1467`		`- free (broken);`
`1468`		`- }`
`1469`	`1470`	`free (num_entries);`
`1470`	`1471`	`free (broken_index);`
`1471`	`1472`	`if (NULL != displs) {`