fix: prefer bun.lockd over yarn.lock (#34)

* test: add test for `findProjectDir()`

* fix: prefer bun.lockd over yarn.lock

* style: format deno fmt

Author: azu

src/utils.ts

@@ -90,6 +90,17 @@ export async function findProjectDir(
     return result;
   }
 
+  // prefer bun.lockb over yarn.lock
+  // In some cases, both bun.lockb and yarn.lock can exist in the same project.
+  // https://bun.sh/docs/install/lockfile
+  const bunLockfile = path.join(dir, "bun.lockb");
+  if (await fileExists(bunLockfile)) {
+    logDebug(`Detected bun from lockfile ${bunLockfile}`);
+    result.projectDir = dir;
+    result.pkgManagerName = "bun";
+    return result;
+  }
+
   const yarnLockFile = path.join(dir, "yarn.lock");
   if (await fileExists(yarnLockFile)) {
     logDebug(`Detected yarn from lockfile ${yarnLockFile}`);
@@ -106,14 +117,6 @@ export async function findProjectDir(
     return result;
   }
 
-  const bunLockfile = path.join(dir, "bun.lockb");
-  if (await fileExists(bunLockfile)) {
-    logDebug(`Detected bun from lockfile ${bunLockfile}`);
-    result.projectDir = dir;
-    result.pkgManagerName = "bun";
-    return result;
-  }
-
   const pkgJsonPath = path.join(dir, "package.json");
   if (await fileExists(pkgJsonPath)) {
     logDebug(`Found package.json at ${pkgJsonPath}`);

test/utils.test.ts

@@ -0,0 +1,54 @@
+import * as assert from "assert/strict";
+import * as fs from "fs";
+import * as path from "node:path";
+import { runInTempDir } from "./test_utils";
+import { findProjectDir } from "../src/utils";
+
+describe("findProjectDir", () => {
+  it("should return npm if package-lock.json is found", async () => {
+    await runInTempDir(async (tempDir) => {
+      await fs.promises.writeFile(
+        path.join(tempDir, "package-lock.json"),
+        "{}",
+        "utf-8",
+      );
+      const result = await findProjectDir(tempDir);
+      assert.strictEqual(result.pkgManagerName, "npm");
+    });
+  });
+  it("should return yarn if yarn.lock is found", async () => {
+    await runInTempDir(async (tempDir) => {
+      await fs.promises.writeFile(path.join(tempDir, "yarn.lock"), "", "utf-8");
+      const result = await findProjectDir(tempDir);
+      assert.strictEqual(result.pkgManagerName, "yarn");
+    });
+  });
+  it("should return pnpm if pnpm-lock.yaml is found", async () => {
+    await runInTempDir(async (tempDir) => {
+      await fs.promises.writeFile(
+        path.join(tempDir, "pnpm-lock.yaml"),
+        "",
+        "utf-8",
+      );
+      const result = await findProjectDir(tempDir);
+      assert.strictEqual(result.pkgManagerName, "pnpm");
+    });
+  });
+  it("should return bun if bun.lockb is found", async () => {
+    await runInTempDir(async (tempDir) => {
+      await fs.promises.writeFile(path.join(tempDir, "bun.lockb"), "", "utf-8");
+      const result = await findProjectDir(tempDir);
+      assert.strictEqual(result.pkgManagerName, "bun");
+    });
+  });
+  it("should return bun if bun.lockb and yarn.lock are found", async () => {
+    // bun allow to save bun.lockb and yarn.lock
+    // https://bun.sh/docs/install/lockfile
+    await runInTempDir(async (tempDir) => {
+      await fs.promises.writeFile(path.join(tempDir, "bun.lockb"), "", "utf-8");
+      await fs.promises.writeFile(path.join(tempDir, "yarn.lock"), "", "utf-8");
+      const result = await findProjectDir(tempDir);
+      assert.strictEqual(result.pkgManagerName, "bun");
+    });
+  });
+});