LoopbackCache: make Close atomic

yousong · yousong · commit f20de6d55044 · 2024-07-16T01:21:48.000Z
diff --git a/fs/content_cache.go b/fs/content_cache.go
@@ -100,10 +100,9 @@ func (l *LoopbackCache) Open(id string) (*os.File, error) {
 
 // Close closes the currently open fd
 func (l *LoopbackCache) Close(id string) {
-	if fd, ok := l.fds.Load(id); ok {
+	if fd, ok := l.fds.LoadAndDelete(id); ok {
 		file := fd.(*os.File)
 		file.Sync()
 		file.Close()
-		l.fds.Delete(id)
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -100,10 +100,9 @@ func (l LoopbackCache) Open(id string) (os.File, error) {`
`100`	`100`
`101`	`101`	`// Close closes the currently open fd`
`102`	`102`	`func (l *LoopbackCache) Close(id string) {`
`103`		`- if fd, ok := l.fds.Load(id); ok {`
	`103`	`+ if fd, ok := l.fds.LoadAndDelete(id); ok {`
`104`	`104`	`file := fd.(*os.File)`
`105`	`105`	`file.Sync()`
`106`	`106`	`file.Close()`
`107`		`- l.fds.Delete(id)`
`108`	`107`	`}`
`109`	`108`	`}`