Make SqlCertificateDatabase a proper base class for other database providers. (#1218)

Allow SqlCertificateDatabase subclasses to override parameter name syntax.

---------

Co-authored-by: Benjamin Rauch <rauch.bfh@gmail.com>
Co-authored-by: Jeffrey Stedfast <jestedfa@microsoft.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Author: 4 people

MimeKit/Cryptography/NpgsqlCertificateDatabase.cs

@@ -128,7 +128,7 @@ protected override IList<DataColumn> GetTableColumns (DbConnection connection, s
 		{
 			using (var command = CreateCommand ()) {
 				command.CommandText = $"PRAGMA table_info({tableName})";
-				using (var reader = command.ExecuteReader ()) {
+				using (var reader = ExecuteReader (command)) {
 					var columns = new List<DataColumn> ();
 
 					while (reader.Read ()) {
@@ -232,7 +232,7 @@ protected override void CreateTable (DbConnection connection, DataTable table)
 			using (var command = CreateCommand ()) {
 				command.CommandText = statement.ToString ();
 				command.CommandType = CommandType.Text;
-				command.ExecuteNonQuery ();
+				ExecuteNonQuery (command);
 			}
 		}
 
@@ -257,7 +257,7 @@ protected override void AddTableColumn (DbConnection connection, DataTable table
 			using (var command = CreateCommand ()) {
 				command.CommandText = statement.ToString ();
 				command.CommandType = CommandType.Text;
-				command.ExecuteNonQuery ();
+				ExecuteNonQuery (command);
 			}
 		}
 	}

MimeKit/Cryptography/SQLServerCertificateDatabase.cs

@@ -105,7 +105,7 @@ protected override void AddTableColumn (DbConnection connection, DataTable table
 			using (var command = CreateCommand ()) {
 				command.CommandText = statement.ToString ();
 				command.CommandType = CommandType.Text;
-				command.ExecuteNonQuery ();
+				ExecuteNonQuery (command);
 			}
 		}
 
@@ -137,7 +137,7 @@ protected override void CreateTable (DbConnection connection, DataTable table)
 			using (var command = CreateCommand ()) {
 				command.CommandText = statement.ToString ();
 				command.CommandType = CommandType.Text;
-				command.ExecuteNonQuery ();
+				ExecuteNonQuery (command);
 			}
 		}
 
@@ -190,7 +190,7 @@ protected override IList<DataColumn> GetTableColumns (DbConnection connection, s
 		{
 			using (var command = CreateCommand ()) {
 				command.CommandText = $"select top 1 * from {tableName}";
-				using (var reader = command.ExecuteReader ()) {
+				using (var reader = ExecuteReader (command)) {
 					var columns = new List<DataColumn> ();
 					var table = reader.GetSchemaTable ();
 
@@ -218,7 +218,7 @@ protected override void CreateIndex (DbConnection connection, string tableName,
 
 			using (var command = CreateCommand ()) {
 				command.CommandText = query;
-				command.ExecuteNonQuery ();
+				ExecuteNonQuery (command);
 			}
 		}
 
@@ -238,7 +238,7 @@ protected override void RemoveIndex (DbConnection connection, string tableName,
 
 			using (var command = CreateCommand ()) {
 				command.CommandText = query;
-				command.ExecuteNonQuery ();
+				ExecuteNonQuery (command);
 			}
 		}