fix: add better logging

jstrachan · jstrachan · commit 7300a1ef9f2a · 2019-09-20T18:16:14.000+01:00
diff --git a/scm/factory/factory.go b/scm/factory/factory.go
@@ -98,8 +98,12 @@ func NewClientFromEnvironment() (*scm.Client, error) {
 	if oauthToken == "" {
 		return nil, fmt.Errorf("No Git OAuth token specified for $GIT_TOKEN")
 	}
+	client, err := NewClient(driver, serverURL, oauthToken)
+	if driver == "" {
+		driver = client.Driver.String()
+	}
 	fmt.Printf("using driver: %s and serverURL: %s\n", driver, serverURL)
-	return NewClient(driver, serverURL, oauthToken)
+	return client, err
 }
 
 // ensureGHEEndpoint lets ensure we have the /api/v3 suffix on the URL

Original file line number	Diff line number	Diff line change
`@@ -98,8 +98,12 @@ func NewClientFromEnvironment() (*scm.Client, error) {`
`98`	`98`	`if oauthToken == "" {`
`99`	`99`	`return nil, fmt.Errorf("No Git OAuth token specified for $GIT_TOKEN")`
`100`	`100`	`}`
	`101`	`+ client, err := NewClient(driver, serverURL, oauthToken)`
	`102`	`+ if driver == "" {`
	`103`	`+ driver = client.Driver.String()`
	`104`	`+ }`
`101`	`105`	`fmt.Printf("using driver: %s and serverURL: %s\n", driver, serverURL)`
`102`		`- return NewClient(driver, serverURL, oauthToken)`
	`106`	`+ return client, err`
`103`	`107`	`}`
`104`	`108`
`105`	`109`	`// ensureGHEEndpoint lets ensure we have the /api/v3 suffix on the URL`