geoip: avoid crash cleaning non-existing managed dbs (elastic#15986)

* geoip: avoid crash cleaning non-existing managed dbs

* Update x-pack/spec/geoip_database_management/manager_spec.rb

Co-authored-by: João Duarte <[email protected]>

---------

Co-authored-by: João Duarte <[email protected]>

Author: yaauie

x-pack/lib/geoip_database_management/manager.rb

@@ -59,9 +59,13 @@ def initialize
     @metadata = Metadata.new(data_path)
 
     unless enabled?
-      logger.info("database manager is disabled; removing managed databases from disk``")
-      metadata.delete
-      clean_up_database
+      if @metadata.exist?
+        logger.info("database manager is disabled; removing managed databases from disk``")
+        metadata.delete
+        clean_up_database
+      else
+        logger.info("database manager is disabled.")
+      end
     end
   end
 
@@ -142,6 +146,8 @@ def periodic_sync
   end
 
   def clean_up_database(excluded_dirnames = [])
+    return unless ::Dir.exist?(data_path.root)
+
     protected_dirnames = excluded_dirnames.uniq
     existing_dirnames = ::Dir.children(data_path.root)
                              .select { |f| ::File.directory? ::File.join(data_path.root, f) }

x-pack/spec/geoip_database_management/manager_spec.rb

@@ -37,10 +37,13 @@ def write_dummy_mmdb(type, path)
   let(:geoip_data_path) { ::File.expand_path("geoip_database_management", settings_path_data)}
   let(:geoip_metadata_path) { ::File.expand_path("metadata.csv", geoip_data_path) }
 
+  let(:populate_geoip_data_path) { true }
   let(:metadata_contents) { nil }
   before(:each) do
-    ::FileUtils.mkdir_p(::File.dirname(geoip_metadata_path))
-    ::File.write(geoip_metadata_path, metadata_contents) unless metadata_contents.nil?
+    if populate_geoip_data_path
+      ::FileUtils.mkdir_p(::File.dirname(geoip_metadata_path))
+      ::File.write(geoip_metadata_path, metadata_contents) unless metadata_contents.nil?
+    end
   end
 
   after(:each) do
@@ -106,6 +109,18 @@ def write_dummy_mmdb(type, path)
         expect(Pathname(existing_city_db_path)).to_not be_file
         expect(Pathname(existing_asn_db_path)).to_not be_file
       end
+
+      context "and data directory does not exist" do
+        let(:populate_geoip_data_path) { false }
+        let(:existing_city_db_path) { nil }
+        let(:existing_asn_db_path) { nil }
+
+        it 'logs info about database manager being disabled' do
+          manager_instance # instantiate
+
+          expect(mock_logger).to have_received(:info).with(a_string_including "database manager is disabled")
+        end
+      end
     end
   end