Skip to content

Commit 0fcf3ef

Browse files
authored
Merge pull request #437 from taddei/master
[Fix] added JSXText as a valid accessible child
2 parents cca4ff7 + 595b68f commit 0fcf3ef

File tree

2 files changed

+10
-0
lines changed

2 files changed

+10
-0
lines changed

__tests__/src/util/hasAccessibleChild-test.js

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,15 @@ describe('hasAccessibleChild', () => {
3636
expect(hasAccessibleChild(element)).toBe(true);
3737
});
3838

39+
it('Returns true for JSXText Element', () => {
40+
const child = {
41+
type: 'JSXText',
42+
value: 'foo',
43+
};
44+
const element = JSXElementMock('div', [], [child]);
45+
expect(hasAccessibleChild(element)).toBe(true);
46+
});
47+
3948
it('Returns false for hidden child JSXElement', () => {
4049
const ariaHiddenAttr = JSXAttributeMock('aria-hidden', true);
4150
const child = JSXElementMock('div', [ariaHiddenAttr]);

src/util/hasAccessibleChild.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ export default function hasAccessibleChild(node: JSXElement): boolean {
88
return node.children.some((child) => {
99
switch (child.type) {
1010
case 'Literal':
11+
case 'JSXText':
1112
return Boolean(child.value);
1213
case 'JSXElement':
1314
return !isHiddenFromScreenReader(

0 commit comments

Comments
 (0)