Remove onclick-has-role test

Author: jessebeach

__tests__/src/rules/onclick-has-role-test.js

@@ -1,20 +1,31 @@
 # no-noninteractive-element-handlers
 
-Write a useful explanation here!
+Enforce visible, non-interactive elements with click handlers use role attribute. Visible means that it is not hidden from a screen reader. Examples of non-interactive elements are `div`, `section`, and `a` elements without a href prop. The purpose of the role attribute is to identify to screenreaders the exact function of an element. This rule will only test low-level DOM components, as we can not deterministically map wrapper JSX components to their correct DOM element.
+
+In cases where a non-interactive element has a handler, but does not map to an interactive role such as `button` or `link` -- for example a `div` container that catches bubbled click events -- `onclick-has-role` may be satisfied by providing a role value of `presentation`. This indicates that the element has no semantic value. A role like `button` or `link` should only be applied when the non-interactive element truly represents such a UI element.
 
 #### References
-1.
+1. [MDN](https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_button_role#Keyboard_and_focus)
 
 ## Rule details
 
 This rule takes no arguments.
 
 ### Succeed
 ```jsx
-<div />
+<div onClick={() => void 0} role="button" />
+<div onClick={() => void 0} role="presentation" />
+<input type="text" onClick={() => void 0} /> // Interactive element does not require role.
+<a tabIndex="0" onClick={() => void 0} /> // tabIndex makes this interactive.
+<button onClick={() => void 0} className="foo" /> // button is interactive.
+<div onClick={() => void 0} role="button" aria-hidden /> // This is hidden from screenreader.
+<Input onClick={() => void 0} type="hidden" /> // This is a higher-level DOM component
 ```
 
 ### Fail
 ```jsx
-
+<div onClick={() => void 0} />
+<div onClick={() => void 0} {...props} />
+<div onClick={() => void 0} aria-hidden={false} />
+<a onClick={() => void 0} />
 ```

docs/rules/no-noninteractive-element-handlers.md

@@ -29,7 +29,6 @@ module.exports = {
     'no-redundant-roles': require('./rules/no-redundant-roles'),
     'no-static-element-interactions': require('./rules/no-static-element-interactions'),
     'onclick-has-focus': require('./rules/onclick-has-focus'),
-    'onclick-has-role': require('./rules/onclick-has-role'),
     'role-has-required-aria-props': require('./rules/role-has-required-aria-props'),
     'role-supports-aria-props': require('./rules/role-supports-aria-props'),
     scope: require('./rules/scope'),
@@ -69,7 +68,6 @@ module.exports = {
         'jsx-a11y/no-redundant-roles': 'error',
         'jsx-a11y/no-static-element-interactions': 'warn',
         'jsx-a11y/onclick-has-focus': 'error',
-        'jsx-a11y/onclick-has-role': 'error',
         'jsx-a11y/role-has-required-aria-props': 'error',
         'jsx-a11y/role-supports-aria-props': 'error',
         'jsx-a11y/scope': 'error',