[Refactor] this falsy condition is impossible in a rule, because JSXAttribute can’t ever have a falsy propName.

If it does in the future, then that would throw an error - which would surface the bug, instead of silently avoiding it.

Author: ljharb

src/rules/aria-props.js

@@ -36,7 +36,7 @@ module.exports = {
   create: context => ({
     JSXAttribute: (attribute) => {
       const name = propName(attribute);
-      const normalizedName = name ? name.toLowerCase() : '';
+      const normalizedName = name.toLowerCase();
 
       // `aria` needs to be prefix of property.
       if (normalizedName.indexOf('aria-') !== 0) {

src/rules/aria-proptypes.js

@@ -63,7 +63,7 @@ module.exports = {
   create: context => ({
     JSXAttribute: (attribute) => {
       const name = propName(attribute);
-      const normalizedName = name ? name.toLowerCase() : '';
+      const normalizedName = name.toLowerCase();
 
       // Not a valid aria-* state or property.
       if (normalizedName.indexOf('aria-') !== 0 || aria.get(normalizedName) === undefined) {

src/rules/aria-role.js

@@ -41,10 +41,9 @@ module.exports = {
       }
 
       // Get prop name
-      const name = propName(attribute);
-      const normalizedName = name ? name.toUpperCase() : '';
+      const name = propName(attribute).toUpperCase();
 
-      if (normalizedName !== 'ROLE') { return; }
+      if (name !== 'ROLE') { return; }
 
       const value = getLiteralPropValue(attribute);
 

src/rules/aria-unsupported-elements.js

@@ -47,10 +47,9 @@ module.exports = {
           return;
         }
 
-        const name = propName(prop);
-        const normalizedName = name ? name.toLowerCase() : '';
+        const name = propName(prop).toLowerCase();
 
-        if (invalidAttributes.indexOf(normalizedName) > -1) {
+        if (invalidAttributes.indexOf(name) > -1) {
           context.report({
             node,
             message: errorMessage(name),

src/rules/role-has-required-aria-props.js

@@ -26,10 +26,9 @@ module.exports = {
 
   create: context => ({
     JSXAttribute: (attribute) => {
-      const name = propName(attribute);
-      const normalizedName = name ? name.toLowerCase() : '';
+      const name = propName(attribute).toLowerCase();
 
-      if (normalizedName !== 'role') {
+      if (name !== 'role') {
         return;
       }
 

src/rules/tabindex-no-positive.js

@@ -22,11 +22,10 @@ module.exports = {
 
   create: context => ({
     JSXAttribute: (attribute) => {
-      const name = propName(attribute);
-      const normalizedName = name ? name.toUpperCase() : '';
+      const name = propName(attribute).toUpperCase();
 
       // Check if tabIndex is the attribute
-      if (normalizedName !== 'TABINDEX') {
+      if (name !== 'TABINDEX') {
         return;
       }