Clean up img alt implementation.

Author: Ethan Cohen

lib/rules/img-uses-alt.js

@@ -18,18 +18,16 @@ module.exports = function(context) {
 
   return {
     JSXOpeningElement: function(node) {
-      var hasAltProp = node.attributes.some(function(attribute, idx, attrs) {
-        // If the only attribute is a spread attribute, then pass rule.
-        if (attribute.type === 'JSXSpreadAttribute' && attrs.length === 1) {
+      var hasAltProp = node.attributes.some(function(attribute) {
+        // If the attributes contain a spread attribute, then pass rule.
+        if (attribute.type === 'JSXSpreadAttribute') {
           return true;
-        } else if (attribute.type === 'JSXSpreadAttribute') {
-          return false;
         }
 
         return attribute.name.name.toUpperCase() === 'ALT';
       });
 
-      if (!hasAltProp) {
+      if (hasAltProp === false) {
         context.report({
           node: node,
           message: 'IMG element must have alt tag.'

package.json

@@ -13,7 +13,7 @@
     "coveralls": "cat ./reports/coverage/lcov.info | coveralls",
     "lint": "eslint ./",
     "test": "npm run lint && npm run unit-test",
-    "unit-test": "istanbul cover --dir reports/coverage node_modules/mocha/bin/_mocha tests/**/*.js -- --reporter dot"
+    "unit-test": "istanbul cover --dir reports/coverage node_modules/mocha/bin/_mocha tests/**/*.js -- --reporter nyan"
   },
   "devDependencies": {
     "babel-eslint": "5.0.0-beta10",

tests/lib/rules/img-uses-alt.js

@@ -39,6 +39,7 @@ ruleTester.run('img-uses-alt', rule, {
     {code: '<img {...this.props} />', parserOptions: parserOptions}
   ],
   invalid: [
-    {code: '<img />;', errors: [expectedError], parserOptions: parserOptions}
+    {code: '<img />;', errors: [expectedError], parserOptions: parserOptions},
+    {code: '<img src="xyz" />', errors: [expectedError], parserOptions: parserOptions}
   ]
 });