Skip to content

Commit 318a461

Browse files
committed
Clean up the pithy violation phrases
1 parent 3327a82 commit 318a461

6 files changed

+6
-12
lines changed

__tests__/src/rules/interactive-supports-focus-test.js

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,7 @@ import rule from '../../../src/rules/interactive-supports-focus';
1919
const ruleTester = new RuleTester();
2020

2121
const expectedError = {
22-
message: 'An non-interactive element with an onClick handler and an ' +
23-
'interactive role must be focusable. Either set the tabIndex property to ' +
24-
'a valid value (usually 0) or use an element type which is inherently ' +
25-
'focusable such as `button`.',
22+
message: 'Elements with interactive roles must be focusable.',
2623
type: 'JSXOpeningElement',
2724
};
2825

__tests__/src/rules/no-noninteractive-element-interactions-test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ import rule from '../../../src/rules/no-noninteractive-element-interactions';
1919
const ruleTester = new RuleTester();
2020

2121
const errorMessage =
22-
'Visible, non-interactive elements should not have mouse or keyboard event listeners';
22+
'Non-interactive elements should not be assigned mouse or keyboard event listeners.';
2323

2424
const expectedError = {
2525
message: errorMessage,

__tests__/src/rules/no-static-element-interactions-test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ import rule from '../../../src/rules/no-static-element-interactions';
1919
const ruleTester = new RuleTester();
2020

2121
const errorMessage =
22-
'Visible, static elements should not have mouse or keyboard event listeners';
22+
'Static HTML elements with event handlers require a role.';
2323

2424
const expectedError = {
2525
message: errorMessage,

src/rules/interactive-supports-focus.js

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,7 @@ import getTabIndex from '../util/getTabIndex';
2626
// ----------------------------------------------------------------------------
2727

2828
const errorMessage =
29-
'An non-interactive element with an onClick handler and an ' +
30-
'interactive role must be focusable. Either set the tabIndex property to ' +
31-
'a valid value (usually 0) or use an element type which is inherently ' +
32-
'focusable such as `button`.';
29+
'Elements with interactive roles must be focusable.';
3330

3431
const schema = generateObjSchema();
3532
const domElements = [...dom.keys()];

src/rules/no-noninteractive-element-interactions.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ import isNonInteractiveRole from '../util/isNonInteractiveRole';
2626
import isPresentationRole from '../util/isPresentationRole';
2727

2828
const errorMessage =
29-
'Visible, non-interactive elements should not have mouse or keyboard event listeners';
29+
'Non-interactive elements should not be assigned mouse or keyboard event listeners.';
3030

3131
const schema = generateObjSchema();
3232

src/rules/no-static-element-interactions.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ import isNonInteractiveRole from '../util/isNonInteractiveRole';
2727
import isPresentationRole from '../util/isPresentationRole';
2828

2929
const errorMessage =
30-
'Visible, static elements should not have mouse or keyboard event listeners';
30+
'Static HTML elements with event handlers require a role.';
3131

3232
const schema = generateObjSchema();
3333

0 commit comments

Comments
 (0)